Repository navigation
Test save and reload for complex scenes (#482) - #511
Merged
Merged
Conversation
Saves a scene with mixed image edits (move, resize, rotate, flip, crop, order) and text/line/region annotations, reopens it from a fresh store, and compares every field. Covers re-saving after reordering, discarding unsaved changes, and failed saves (storage error, invalid content, stale copy).
Subomiadekunle
requested review from
jacksayshi,
leandrumartin and
mudabs
as code owners
October 25, 2026 23:18
mudabs
approved these changes
Oct 28, 2026
mudabs
left a comment
Collaborator
There was a problem hiding this comment.
Approved
Thank you Subomi for the thorough test coverage. This PR verifies that complex scenes preserve image properties, annotation properties, layer ordering, edits after a second save, and the last saved version after discarded changes.
The failure cases for storage errors, invalid content, and stale scene versions are also valuable because they confirm that failed saves do not overwrite the previously saved scene.
I ran the focused test suite and the full test suite successfully, and lint is clean. I’m approving this PR.
Collaborator
|
I also appreciate the manual image verifications! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #482 (part of #477)
Adds
boneset-api/saveReload.test.js, which checks that saved scenes come back with complete visual fidelity.What's tested
templates/tests/scenes.test.js("discards the copy without storing it when the user agrees").Manual verification
Created a scene, imported Ilium with labels and regions, then moved, resized, rotated, flipped, cropped, and reordered images. Saved, refreshed the page, and reopened: everything matched. Made another edit, discarded it, and reopened: the edit was gone.
Testing
npx jest boneset-api/saveReload.test.js: 11 tests passnpm test: all suites passnpm run lint: clean