Conversation
maschwenk
added
the
coder-task-generated
|
Thanks for your contribution! This PR doesn't have a linked issue. All PRs must reference an existing issue. Please:
See CONTRIBUTING.md for details. |
|
This PR doesn't fully meet our contributing guidelines and PR template. What needs to be fixed:
Please edit this PR description to address the above within 2 hours, or it will be automatically closed. If you believe this was flagged incorrectly, please let a maintainer know. |
|
The following comment was made by an LLM, it may be inaccurate: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Chrome Forge V2 repro: task switching sometimes silently resets the transcript scrollTop to 0 while the virtualizer retains rows for the previous offset, leaving a blank region. This branch recovers that offset and restores the September 15 document-adoption binding guard from #22. The guard was lost when the Owner submodule pin moved from 56aecee to the separate V2 compatibility branch.
The Owner preview at https://github.com/owner/Owner/pull/70381 previously exercised ten desktop switches on the offset-recovery-only commit: four resets recovered in 38-227 ms with no lasting blank region, though a brief flash remained. The combined fix is now deployed to that preview at Owner commit 164d5c17abd. Local Forge UI typecheck and production build passed. The two original tasks are currently paused or stopping, so the combined fix has not yet had an equivalent live-switch comparison. Keep this draft until that validation is possible. This PR builds on #24.