Drop instanceState row hack from instance NIC and disk tables - #3365
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Collaborator
Author
|
Temporarily pushing a test that proves the changes doesn't break anything, but the tests aren't worth keeping so I'm going to revert them and put in a smaller vitest browser test. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We had a hack in a couple of spots to prevent certain row actions componenents from unmounting and remounting, which would cause an open row actions menu to close. #3364 makes the hack unnecessary, so we remove it. 4dccaed adds e2e tests for those exact scenarios and shows they pass in CI. But those tests are too specific, so they're not worth keeping around. The next commit reverts them. The last one adds a vitest browser test that is a little more general, showing how an open menu behaves when its underlying state changes (in this case a button going from disabled to enabled).