[tjcouch-sil]

Summary

This is the scripture-editors half of the PT-4197 end-to-end data-fidelity audit. It covers two things:

• Test coverage: the full load and save trip over the real per-chapter USX from paranext-core's data provider, in every view a user can edit Scripture in.
• Fixes: the Scripture losses and unasked edits that this work found. Where Paratext 9's behavior is the reference, the fixes match it.

Companion: paranext/paranext-core#2922, which holds the authoritative loss catalog .context/standards/Scripture-Data-Fidelity-Catalog.md. Merge this first, then move platform-yalc. Core's CI stays red until then: core has dropped its version shims and consumes the new editor option.

Why review this

Part of the Standard-view epic (PT-4186); PT-4197 is its data-fidelity work item. The goal is no Scripture data loss and no automatic edits the user didn't ask for.

Test nets

• Composed round trip (corpus-pdp-usx-composed-round-trip.test.tsx): real data-provider USX → converters → mounted Editor → USX, in Standard, formatted and paragraph-structure (Simple mode's view).
• USX-first converter net.
• USJ-first converter net (testusfm-usj-usx-round-trip.test.ts) now discovers every oracle in the corpus, so 2SA-4, 2SA-5, 1SA-1 and spacing-word-break are covered too.
• Unclosed spans under editing (unclosedSpanEditing.test.tsx): typing, Backspace and a paragraph split inside a span the USFM never closed, and typing before it, in every editing view; every span still saves closed="false" in the USJ and in the USX the provider receives. What ParatextData then writes from the editor's USX is pinned in paranext-core#2922's editor-first round trip.
• One view registry (editorViews.test-helpers.tsx). Every applicable suite runs over the editing views from it.
  • Each view is labelled with the app surface it guards (power-standard, simple, footnotes-pane-row, preview, read-only-panel, library-only). The footnotes pane's row editor is a named entry (footnotes-pane-row), and READ_ONLY_VIEWS lists Power mode's Preview and the text grid's block-verse column, mounted read-only.
  • Read-only sweep (readOnlyGestures.test.tsx, 110 tests): every gesture (typing, Enter, deletes, paste in three flavors, cut, the shortcuts, drop, undo/redo, and the ref's editing methods) leaves every read-only view unchanged, and each gesture is shown to change an editable view.
  • Library-only views are opt-in. Views Platform.Bible doesn't offer (editable formatted, unformatted, the Markers view, Standard with expanded notes, the popover over a non-Standard host) run only with SE_TEST_LIBRARY_VIEWS=1 (pnpm test:library-views in packages/platform); CI and the default run skip them. That now includes the ~95 tests that built Standard-with-expanded-notes options themselves (mountExpandedNoteEditor, testEnvironmentExpanded, or the options spelled out) rather than naming the registry view. Default platform run ~339 s, ~587 s with them (at 8163d705).
  • Rows that tested app-reachable code only through a library-only view now have twins in the app's views: read-only suites run Preview instead of formatted, decorator rows run in Preview and Simple, note-content clipboard rows run in the footnotes pane's row editor, plus new rows for HTML paragraphs pasted in Simple and a pending \cat edit in the footnotes pane.
  • Of those ~95 Standard-with-expanded-notes tests: 9 were already repeated by the Standard rows of the same tables; 34 got twins in the footnotes pane's row editor over the one-note scaffold it mounts (paneRowScaffold / mountInPaneRow): note-content annotations, settles, whitespace, separators, the \cat run, caller-end and closer locations, adaptor rows; 45 run in Standard view instead, because Standard shows a note with no closer expanded with its shell editable, or the row never needed expanded notes (husk and stale-basis positions, selectNote, the paragraph-prefix default); 5 stay library-only (a closed note's closer as editable glyph text, and content pending inside a collapsed note). Each new row was turned red by breaking the behaviour it pins. Flag-off coverage keeps every production statement (lines/statements/branches 19,151/21,930/15,970 → 19,150/21,930/15,975); the only lost branches are the closer half of a closed note's opener rename, which needs an editable closed-note shell.
• Typing-fidelity oracle for formatted and paragraph-structure. For every keystroke at every caret position it checks:
  • only the edited spot changed;
  • nothing was invented or lost;
  • Undo and Redo are exact.
• Copy/cut/paste corpus: 543 rows.
• Per-keystroke content check in the pending/settled oracle.
• Corpus: testUSFM 2SA-4, 2SA-5 (damaged but at rest) and 1SA-1 (introduction), plus the pdp-usx/ captures.

Tickets filed by this work: PT-4909, PT-4910, PT-4911, PT-4921, PT-4924, PT-4925, PT-4931 (long-term real-NBSP representation) and PT-4952 (Standard view's character-marker remove/replace). The deferred delta-op format items (span identity in ops among them) went to the existing PT-4399.

Known defects are pinned as shrink-only expected failures, each naming its ticket. For example, the clipboard pins name PT-4911 and PT-4921, and the typing pins name PT-4924. When a fix lands, the pinned test starts passing and fails the suite.

Fixes

• USX/USJ version is preserved end to end. Usj.version is now string. A declared version that isn't 3.x passes through unchanged too; the converters don't validate or upgrade it (TSDoc, 2.5 test cases).
• PT-4391: an authored lone NBSP survives outside Standard view, including the cases where editing leaves it alone in a span.
• Projects with Paratext's AllowInvisibleChars on: the new documented option ViewOptions.allowInvisibleCharacters keeps ~ and U+00A0 verbatim. Standard view used to turn a literal ~ into an NBSP on save.
  • The editor holds a no-break space as a U+001A stand-in, drawn as a blank by a one-glyph webfont. Every boundary passes a real U+00A0: change ops, note ops, the footnote popover, applyUpdate, the Lexical copy flavor, async paste, drag/drop, annotation text and the caller preview (nbspStandIn.test.tsx). Incoming C0 control characters become spaces in Standard view.
  • An attribute value keeps its ~ and its U+00A0 apart under either setting, as Paratext 9 does (catalog O-12; attributeValueNbsp.test.tsx, usfmFragmentToUsj.test.ts). Paratext 9 reads ~ as a no-break space only in body text. Standard and Unformatted views now hold a value's U+00A0 as the stand-in with the setting on or off, only the stand-in reads back as U+00A0, and a value's ~ is never touched; with the setting off a settle used to save the author's ~ as U+00A0. This covers milestones, char-span attributes, figures, \cat, \ca/\cp, \va and a folded \vp; \periph, an unfolded \vp and the bytes an unwrapped span leaves behind stay body text.
  • A U+00A0 pasted with the caret inside a value saves as U+00A0 with the setting on and as ~ with it off, as Paratext 9 pastes one; it used to save as a space. A value's U+00A0 copies as U+00A0 under either setting, and toUsfmNbspSpelling always turns the stand-in into U+00A0.
  • The stand-in's font family is no longer exported (NBSP_STAND_IN_FONT_FAMILY is gone; hosts name PlatformEditorNbspStandIn), and toUsfmNbspSpelling is marked @experimental, since both go away once Standard view holds a real no-break space (PT-4931).
• Paste in Standard view:
  • a pasted no-break space at the start of a line, or on its own, is kept as a no-break space (pastedNbsp.test.tsx);
  • a pasted U+00A0 is read as a marker's separator only right after an opening marker, so a stored no-break space beside a closer or before an opener survives the editor's own copy and paste.
• Delta ops:
  • Standard view's ops carry stored whitespace the way every other view's do, under both settings. This fixes losses in Simple mode's footnotes pane, which edits a paragraph-structure editor's notes in Standard view (noteOpsWhitespace.test.tsx);
  • an author's lone no-break space is kept in op content, and one applied as a char span's whole text is marked authored (appliedNbspContent.test.tsx);
  • text carried out past a note keeps its char spans and milestones (noteCarriedText.test.tsx);
  • milestone ops are emitted under ms, the key the op types declare; applyUpdate still accepts the old milestone key;
  • adjacent char spans whose attributes differ are no longer merged when the footnote editor loads a note from its ops (a second \w span kept its lemma), and spans brought in by one paste stay separate (adjacentCharSpans.test.tsx);
  • in the unformatted view, a note's ~-only span (\ft ~\ft*) and a ~ before a nested span survive the note's ops, the footnote popover and the footnotes pane, and delta-doc positions count an authored \nd ~\nd*, so later positions match the ops stream (lone-nbsp-agreement.test.tsx; agreement tests adapted from Jolie Rabideau's PT-4391: Keep a lone ~ between markers on save in every view #36).
  • an applied insert that extends an existing char span no longer pushes every later op in the same delta too far along, and an applied empty char span gets one placeholder no-break space, not two (delta-apply-update.utils.test.tsx);
  • getOpsAfterNote/takeOpsAfterNote report an empty char span after a note once, so text the footnote editor carries out past a note no longer builds two spans (noteEditorCloseCarriesRest.test.tsx);
  • a char span's separator stays U+00A0 in the ops the editor sends after a retain: an undo that restores it no longer sends the host a leading content space (separatorOpsAfterUndo.test.tsx). Incoming ops are spelled without the document's text, since $applyUpdate places them in apply positions, so a host's no-break space inside a span stays one (misalignedNbspApply.test.tsx);
  • an applied update that removes the paragraph after a \b without bringing any of its content in leaves the blank line's marker alone; a join still keeps the second paragraph's marker, and a range from the blank line over several paragraphs keeps the marker of the paragraph it ends in (ParaNodePlugin.test.tsx, typingFidelity.regressions.test.tsx);
  • $getApplyLength counts each leaf with the shared $getNodeOTContribution(node, "apply") rules.
• Invisible characters are typed, pasted and copied as in Paratext 9 (TJ's rulings, 2026-10-29; InvisibleCharactersPlugin, invisibleCharacters.test.tsx):
  • with allowInvisibleCharacters off, a no-break space typed as a character goes in as a space in every view, not only Standard (Simple saved ~); a pasted one is still a no-break space, and with the setting on both are kept;
  • a zero-width no-break space (U+FEFF) typed, pasted (every flavor) or dropped is dropped, in every view and either setting; one the document already holds is kept by the editor, so loading or editing elsewhere never changes it (paranext-core#2922 drops it from what an edit saves, as Paratext 9 does);
  • with the setting off, a view that hides markers copies a stored no-break space as ~ in its plain text; layout spacing (gutter markers, empty-span placeholders, note spacers) and the html and internal flavors keep U+00A0, which the view's own paste reads back as the no-break space.
• A read-only editor no longer takes a paste from the keyboard. ClipboardPlugin listens on the editor root, outside Lexical's read-only gate, so Ctrl+V / Ctrl+Shift+V pasted into the Preview, resource panels and the text grid. The shortcuts now paste and cut only in an editable editor; Ctrl+C still copies, and Ctrl+X no longer dispatches a cut there.
• Copying a whole note through the editor's own copy is pinned (wholeNoteCopy.test.tsx).
• Footnotes:
  • An empty note caller is read and written as caller="", as ParatextData does; an every-view test locks it (O-4).
  • Enter inside an expanded note does nothing where markers aren't editable (NoteEnterGuardPlugin); \fp support is PT-4909.
  • A nameless character marker in a note keeps its empty name.
• Typing in hidden-marker views:
  • range edits across nested spans and footnotes;
  • joining into an empty \b keeps the joined paragraph, as Paratext 9 does; deleting an empty paragraph after a \b (Delete or Backspace from inside it) leaves the blank line a \b;
  • Delete before a collapsed note no longer crashes;
  • Undo of Enter;
  • Backspace between a span and a collapsed note;
  • alike spans stay apart, as in Standard view, while a span that Enter split is one span again when Backspace joins the paragraphs back;
  • Enter at a word break drops the space in Simple, as in the other views;
  • Undo after Simple's two-press removal of an empty paragraph (an empty \b) brings it back;
  • Redo works after an Undo leaves the caret beside an empty verse or a trailing note (the invisible caret host is no longer an undo step of its own).
• Applying a character marker in hidden-marker views:
  • a newly marked span stays apart from an alike span beside it (marking "God" after \nd Lord\nd* makes a second span), as Paratext 9 and Standard view do;
  • a selection overlapping part of an alike span extends that span: a deliberate departure from Paratext 9, which mangles the line there (TJ's ruling);
  • applying a marker over a selection that starts or ends inside a span no longer hangs the editor (adjacentCharSpans.test.tsx).
  • styling a selection of exactly one stored ~ keeps it inside the new span; it saved an empty span and lost the ~ (lone-nbsp-gestures.test.tsx).
• Applying a character marker across a span's marker border (markerApplyAcrossSpans.test.tsx):
  • Standard view refuses the apply, logging a warning and changing nothing, when the selection's two ends sit in different spans (an end inside a closing glyph counts as crossing) or inside one glyph; this fixes the \fq endless-transform loop;
  • in every view, a selection holding a whole span or note moves it into the new span intact, which fixes a freeze, a lost \nd and a note's content being marked instead of the note;
  • the leading space of a selection stays outside the new span;
  • the remaining cross-border behaviours are tracked on PT-4609.
• Removing or replacing a character marker over a whole span in hidden-marker views (charMarkerSelectionEdge.test.tsx): a double-click or drag over a whole span ends at the start of the text after it, which Lexical records as a point on the span element. $getSelectionOffsets now reads that as the end of the span's text, so removing \add from "God" no longer leaves G\add od\add*, replacing it no longer splits it, and removing \nd from a span ending in a nested span works. The same fix covers extend and the apply path's same-marker check. Pre-existing on main. Standard view's remove/replace is broken even for plain selections but is not reachable from the UI; tracked on PT-4952.
• In Simple mode, a Backspace or Delete that would run into a chapter is refused, including word and line deletes and deletes with no keydown. The letters beside a chapter stay editable (2a67a7e3), and an empty paragraph beside a chapter can still be removed. A range selected across a chapter is not guarded: one press removes it, chapter included, and the two paragraphs join.
• Structure protection holds for edits that arrive with no keydown in the views that hide markers: under protected, an input method's composition, text insertion or a character delete (macOS Ctrl+H) over a range holding a verse marker or crossing a paragraph is refused, and under guarded such a delete arms the two-step confirm as Backspace does (inlineRangeStructureProtection.test.tsx).
• Typing over a range whose two edge texts are wholly selected keeps the text after a char span outside it.
• An input method or dead key composing over a range across a span edge or a collapsed note now takes only the selected text, as typing does (InlineRangeEditPlugin): \wj Lord said\wj* to them with "said to" selected composes to \wj Lord é\wj* them, where the following text used to land in the span. The plugin handles the placeholder Lexical inserts when a composition starts, so the selected text goes at the same moment it always did.
• Typing only a zero-width no-break space over a selection leaves the selection in place. The character is dropped; it used to delete the selection.
• Enter just before a space followed by a no-break, ideographic or zero-width no-break space no longer removes that character with the space; Paratext 9 keeps it after a marker.
• Clipboard:
  • pasted text stays inside the span or note it was pasted into;
  • a paste over a range across a char span's edge replaces only the selected text in the views that hide markers, as typing does (InlineRangeEditPlugin, pasteOverInlineRange.test.tsx). It used to pull the text after the range into the span, and with nested spans put it ahead of the text it followed. A range that starts where prose meets a span starts in the span, so the pasted text goes in it, again as typing does;
  • a cut no longer strands an NBSP.
• Paratext 9 parity in Standard view:
  • a char span's leading spaces, and a spaces-only span, save as ParatextData saves them;
  • the pending read shows the space before a verse.

AI Involvement

AI-assisted — Claude Code sessions ccea61eb-07b0-4188-96a6-86deef7a1698, this session and two code-review sessions (1, 2), and review-response sessions for the 2026-11-02 reviews (1, 196b7ee4-932a-4fb3-826a-3f23c824acab). Claude subagents generated the plans, tests, fixtures, fixes and triage under a controller session, with independent reviews of the riskier fixes. Claims about Paratext 9 were measured by running ParatextData. TJ directed scope and made every verdict decision.

Testing

At 7bf282e4 (hand-QA fix: usxStringToUsj drops an empty vid, so markers typed into a paragraph that continues a verse settle in Standard view; dist rebuilt and verified current):

• nx run-many -t typecheck lint clean; packages/platform 5290 passed with six 2SA-5 clipboard pins (attributed to PT-4388) now passing and removed; the rest of the PT-4388 pin narrowed to the rows that copy the nameless paragraph marker; utilities, shared, shared-react passed. The new tests were red with the old converter.
• paranext-core restaged on this tip: platform-scripture-editor 5753, platform-scripture 975 and platform-bible-utils 774 passed; the editor-usx resave captures lost only vid="", and ParatextData writes the same bytes from them.

Earlier, at 84465cb0 (the fourth review's three fixes: a protected HTML paste goes through the clipboard-nodes command, a pasted no-break space that Enter strands alone in a span is kept, an over-limit copy writes stored no-break spaces as ~; dist rebuilt and verified current):

• nx run-many -t typecheck lint clean; packages/platform 5288 passed, 63 expected failures, 142 skipped; utilities, shared, shared-react passed. Each new test was red before its fix.
• paranext-core restaged on this tip: platform-scripture-editor 5753 and platform-scripture 975 passed; the editor-usx captures regenerate unchanged.

Earlier, at 6e2473a1 (latest main merged: #45 context menu closes on window blur; dist rebuilt and verified current):

• nx run-many -t typecheck lint clean; packages/platform 5254 passed, 63 expected failures, 142 skipped; utilities, shared, shared-react passed.

Earlier, at cf5d499d (test-only: the USJ-first net over every oracle, the unclosed-span editing suite):

• nx run-many -t typecheck lint clean for all 10 projects.
• packages/platform 5254 passed, 63 expected failures, 142 skipped; utilities, shared and shared-react passed; unclosedSpanEditing.test.tsx also passes with SE_TEST_LIBRARY_VIEWS=1 (30 tests).
• No dist change on this tip (committed dist identical to e0e96429).

Earlier, at e0e96429 (the third review: structure protection for no-keydown edits, the \b empty-paragraph delete, version pass-through docs; dist rebuilt):

• packages/platform with SE_TEST_LIBRARY_VIEWS=1 6900 passed, 70 expected failures, 28 skipped; the whole repo with SE_TEST_LIBRARY_VIEWS=1 (one commit earlier, before the attribute-paste revert) 10328 passed, 70 expected failures, 29 skipped.
• nx run-many -t typecheck -p platform shared-react utilities and nx lint platform clean (existing warnings only); verify-committed-dist.mjs ✓, run last; index.d.ts is the full rollup.
• paranext-core was not restaged against this tip, and the e2e specs were not rerun for this round.

Earlier, at 314da06e (the second 2026-11-02 review: incoming separator-ops revert, multi-paragraph \b join, $getApplyLength; dist rebuilt):

• packages/platform default run 5228 passed, 63 expected failures, 142 skipped; libs/shared-react 2373 passed, 1 skipped.
• tsc --noEmit (lib configs) and eslint clean in shared-react and platform (existing warnings only); verify-committed-dist.mjs ✓, run last.
• The SE_TEST_LIBRARY_VIEWS=1 run and the e2e specs were not rerun for this round.

Earlier, at 45c6bcd6 (the 2026-11-02 review fixes, dist rebuilt; main has nothing newer):

• packages/platform with SE_TEST_LIBRARY_VIEWS=1 6880 passed, 70 expected failures, 28 skipped; the default run, last at 796c589f (before the separator-ops fix), 5209 passed, 63 expected failures, 142 skipped; libs/shared-react 2373 passed, 1 skipped; libs/shared 946.
• nx run-many -t typecheck lint -p shared shared-react platform 0 errors (existing warnings only); the dist rebuild was the last build, index.d.ts the full rollup, no stray Editorial.d.ts.
• paranext-core was not restaged against this tip, and the e2e specs were not rerun for this round.
• TJ needs to finish hand QA.

Earlier, at bea1c90f (the paste and typed-rewrite fixes, main merged including #38 and #39, dist rebuilt), with paranext-core 219408be716 consuming the editor staged from it:

• packages/platform default run 5207 passed, 63 expected failures, 142 skipped; with SE_TEST_LIBRARY_VIEWS=1 6861 passed, 70 expected failures, 28 skipped; libs/shared-react 2367 passed, 1 skipped; libs/shared 945; packages/utilities 89.
• nx run-many -t lint typecheck --projects=platform-editor,shared-react 0 errors (existing warnings only); verify-committed-dist.mjs ✓ after the dist commit, no stray Editorial.d.ts, index.d.ts the full rollup.
• paranext-core: typecheck and lint clean; core 7479 passed, 1 skipped; extensions 7528; dotnet 2964 passed, 14 skipped; all nine no-unasked-edits e2e specs passed on the first attempt (details in paranext-core#2922).

Earlier, at 7912550a (attribute-value ~ fix, value paste, leading-space trim, composition over a range, review follow-ups, dist rebuilt), with paranext-core f2fd54eb9ed consuming the editor staged from it:

• packages/platform default run 5035 passed, 63 expected failures, 142 skipped; with SE_TEST_LIBRARY_VIEWS=1 passed; libs/shared-react 2331 passed, 1 skipped; libs/shared 934; packages/utilities 89 (shared and utilities were last run one source commit earlier, before the composition fix, which touches neither).
• nx run-many -t typecheck lint over all 10 projects: 0 errors (existing warnings only); verify-committed-dist.mjs ✓ after the dist commit.
• paranext-core: typecheck and lint clean; core 7470 passed; platform-scripture-editor 5544; dotnet 2964 passed, 14 skipped; all nine no-unasked-edits e2e specs passed (details in paranext-core#2922).
• TJ checked by hand in the Windows app: Japanese input and the Spanish dead key at a caret, and composing over a selection across a span edge.

Earlier, at 04e3a9df (the Paratext 9 whitespace rulings, CHANGELOG entry, dist rebuilt), with paranext-core beb55bb6fdd consuming the editor staged from it:

• packages/platform default run 5024 passed, 64 expected failures, 142 skipped; with SE_TEST_LIBRARY_VIEWS=1 6551 passed, 71 expected failures, 28 skipped; libs/shared 920; libs/shared-react 2328 passed, 1 skipped; packages/utilities 89.

• nx run-many -t lint typecheck -p shared shared-react platform-editor utilities 0 errors (existing warnings only); verify-committed-dist.mjs ✓ after the dist commit, no stray Editorial.d.ts, index.d.ts the full rollup.

• paranext-core: typecheck and lint clean; core 7470 passed, 1 skipped; platform-scripture-editor 5530; platform-scripture 920; all nine no-unasked-edits e2e specs (including the four invisible-characters specs) passed on the first attempt (--retries=0, one run each).
  Earlier, at 870db8ab (the view registry, read-only sweep and paste fix merged in, CHANGELOG entry added, dist rebuilt) and paranext-core 68eefc1a31b, with core consuming the editor staged from 870db8ab:

• packages/platform default run 4995 passed, 64 expected failures (pins), 126 skipped (245 s, 4 workers); with library-only views (SE_TEST_LIBRARY_VIEWS=1) 6407 passed, 71 expected failures, 24 skipped (442 s); libs/shared 920; libs/shared-react 2328 passed, 1 skipped; packages/utilities 89.

• nx run-many -t lint typecheck -p shared shared-react platform-editor utilities 0 errors (one existing warning); verify-committed-dist.mjs ✓ after the dist commit, no stray Editorial.d.ts, index.d.ts unchanged.

• paranext-core: typecheck and lint clean; core 7470 passed, 1 skipped; extensions 7422 (platform-scripture-editor 5528, platform-scripture 920); platform-bible-utils 736; platform-bible-react 2297 (unit 1659, storybook 638); dotnet 2962 passed, 14 skipped.

• e2e no-unasked-edits (--retries=0, one worker, one run): power-standard, simple-paragraph-structure, power-preview, footnotes-pane-power-standard and footnotes-pane-simple all passed on the first attempt.

• At 8163d705 (Standard-with-expanded-notes rows moved to the app's views): packages/platform default run 4984 passed, 64 expected failures, 142 skipped (257 s, 4 workers, idle machine); with SE_TEST_LIBRARY_VIEWS=1 6488 passed, 71 expected failures, 28 skipped (587 s, measured while an e2e run shared the machine); platform-editor lint and typecheck 0 errors (the existing warning); test-only, verify-committed-dist.mjs ✓ with dist unchanged.

Merging main: main's PT-4885 caret host already tags every host commit history-merge, so this branch's $tagCaretHostCommit gave way to it (the Undo/Redo tests still pass), and main's new mountViewEditor test helper now mounts through this branch's mountInView.

Earlier runs: ccdd06db (all gates green; Standard and Simple e2e passed, the old Power formatted spec failing on main's read-only Preview, since replaced in core), 5dd6f6df (all gates and e2e green on the first attempt), c48eda31 (e2e passed against core 836cc95073f), a7c8a714 after the first code review, d2c0a6f5 after the second (with main merged), a02d0046 (the paste and delta-op fixes; e2e passed first attempt in all three views), and 57e82b05 (the marker-apply and lone-~ follow-ups; the Standard e2e failed its first attempt and passed on rerun), each with the editor tests, lint, typecheck and the dist check green and core restaged and green.

Risk Level

Medium. The typing, NBSP and clipboard fixes change editor behavior, mostly in the hidden-marker views. Each is pinned by gesture-level tests and the oracles, and the riskiest fixes were independently reviewed. The attribute-value change touches the settle path (adaptor, display-run syncs, tokenizer), so it is the one to watch; the typing oracle and pending/settled checks pass. The composition fix can't be fully tested with a real input method in jsdom: its document result is tested with a simulated composition.

🤖 Generated with Claude Code

---

This change is <img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>

---

Generated by Claude Code

[lyonsil]

A third review of this PR's source changes, at 314da06, with 5 findings. Each comment shows the severity it was settled at and a status: checked and confirmed means the finding was verified against the code at this head, and needs a human call means it could not be settled either way and is yours to judge.

(AI-assisted, with my guidance)

[lyonsil]

A fourth review of this PR's source changes, at 6e2473a, with 3 findings. Each comment shows the severity it was settled at and a status: checked and confirmed means the finding was verified against the code at this head, and needs a human call means it could not be settled either way and is yours to judge.

(AI-assisted, with my guidance)

[lyonsil]

@lyonsil reviewed 237 files and all commit messages, made 1 comment, and resolved 24 discussions.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on tjcouch-sil).