Skip to content

Capture authored camera poses through the shared snapshot pipeline - #768

Merged
Aymericr merged 5 commits into
mainfrom
feat/spielberg-shot-capture
Sep 7, 2026
Merged

Capture authored camera poses through the shared snapshot pipeline#768
Aymericr merged 5 commits into
mainfrom
feat/spielberg-shot-capture

Conversation

@Aymericr

@Aymericr Aymericr commented Sep 7, 2026

Copy link
Copy Markdown
Contributor

External camera tools can now request a still from an explicit world-space pose, including roll and output framing, without moving the working viewport. Requests use the existing snapshot pipeline and receive correlated saved/failed events; queued frames restore scene visibility and materials before asynchronous readback.

Background captures no longer trigger manual capture feedback or close an unrelated capture overlay. Manual shutters queue behind uploads; dismissing capture releases movement, and viewport camera changes preserve queued authored frames while scene disposal cancels stale captures. The core barrel also exposes the existing synchronous edit context so external node systems can include derived edits in the originating undo/collaboration transaction. Sidebar rail buttons now expose accessible names and pressed state.

Validation: isolated frozen install with Bun 1.3.14; full lint, check-types, tests, and build passed. The final 19 targeted capture tests pass and cover framing, failures, queueing, restoration, and manual/background event separation.

@pascal

pascal Bot commented Sep 7, 2026

Copy link
Copy Markdown

I hit an error while handling your request (Model unavailable on AI Gateway free tier: Free tier users do not have access to this model. Upgrade to paid credits at https://vercel.com/d?to=%2F%5Bteam%5D%2F%7E%2Fai%3Fmodal%3Dtop-up for unrestricted…).

Please try again, rephrase, or reach out if it keeps failing.

Error id: 3f321fb0-5330-4797-b207-c4e63d42fdcc

@cursor cursor Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Stale Bugbot comment from a previous run.

Comment thread packages/editor/src/components/editor/thumbnail-generator.tsx Outdated

@cursor cursor Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes using high effort and found 2 potential issues.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit 88ef4f6. Configure here.

Comment thread packages/editor/src/components/editor/snapshot-capture-overlay.tsx
Comment thread packages/editor/src/components/editor/thumbnail-generator.tsx
@Aymericr
Aymericr merged commit 505013b into main Sep 7, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant