Repository navigation
announce new versions in the page for the web app and the desktop app - #182
Merged
Merged
Conversation
The web app notices a new release on the server by comparing its bundle with the one index.html names now, checked every ten minutes and when the page comes back into view, and shows a card in the corner with a Reload button. Left alone, the next move to another page reloads instead; dismissed, the card goes and that reload still happens. The desktop app downloads an update as soon as it is found and tells the page through a preload bridge, window.personalAgentProxyDesktop, which the web app shows the same card for with a Restart button, instead of a native dialog. Put off, the update is installed when the app next quits, as before.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The web app now notices a new release on the server by comparing its own bundle with the one
index.htmlnames, every ten minutes and when the page comes back into view, and shows a card in the corner with a Reload button. Left alone, the next move to another page reloads instead, so nothing being typed is lost; dismissed with the X, the card goes and that reload still happens.The desktop app downloads an update as soon as it is found and announces it to the page through a preload bridge (
window.personalAgentProxyDesktop), so the web app shows the same card with a Restart button instead of a native dialog. Put off, the update is still installed when the app next quits. The main process answers only pages on the app's own origin, so a bank's sign-in popup, which inherits the window's preload, cannot trigger a restart.Both halves are covered by tests, and the preload and IPC path was exercised end to end against the dev build. The desktop half ships with the next
desktop-v*release; apps on 0.0.1 take that one update through their old dialog.Open workspace in Conductor