Skip to content

Fix the desktop title bar divider intersection #190

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
arnestrickmann merged 5 commits into from
Nov 5, 2026
Merged

Fix the desktop title bar divider intersection #190

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
19518fb
feat: hide the macOS desktop title bar
arnestrickmann Nov 4, 2026
9ee01d9
docs: describe the hidden desktop title bar
arnestrickmann Nov 4, 2026
2b6ff95
fix: join desktop title bar dividers cleanly
arnestrickmann Nov 5, 2026
1fdeff3
Merge remote-tracking branch 'origin/main' into arnestrickmann/electr…
arnestrickmann Nov 5, 2026
0f1a6bb
chore: keep follow-up diff scoped
arnestrickmann Nov 5, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions packages/desktop/src/preload.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,9 @@ if (process.platform === 'darwin' && window.location.origin === APP_ORIGIN) {
top: 0;
right: 0;
left: 0;
box-sizing: border-box;
height: 2rem;
border-bottom: 1px solid var(--border);
content: '';
-webkit-app-region: drag;
}
Expand Down
4 changes: 4 additions & 0 deletions packages/desktop/src/templates/splash.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@
--background: oklch(1 0 0);
--foreground: oklch(0.145 0 0);
--muted-foreground: oklch(0.556 0 0);
--border: oklch(0.922 0 0);
--primary: oklch(0.205 0 0);
--primary-foreground: oklch(0.985 0 0);
}
Expand All @@ -13,6 +14,7 @@
--background: oklch(0.145 0 0);
--foreground: oklch(0.985 0 0);
--muted-foreground: oklch(0.708 0 0);
--border: oklch(1 0 0 / 10%);
--primary: oklch(0.922 0 0);
--primary-foreground: oklch(0.205 0 0);
}
Expand All @@ -39,8 +41,10 @@ body::before {
top: 0;
right: 0;
left: 0;
box-sizing: border-box;
/* Keep in step with the fallback in preload.ts and the variable in packages/web/src/index.css. */
height: 2rem;
border-bottom: 1px solid var(--border);
content: '';
-webkit-app-region: drag;
}
Expand Down
26 changes: 26 additions & 0 deletions packages/web/src/index.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,9 @@
top: 0;
right: 0;
left: 0;
box-sizing: border-box;
height: var(--desktop-title-bar-height);
border-bottom: 1px solid var(--border);
content: '';
-webkit-app-region: drag;
}
Expand All @@ -31,6 +33,30 @@
top: var(--desktop-title-bar-height);
}

/* The sidebar dividers begin below the title bar. Its bottom border meets them at a clean corner
instead of a vertical line running between the traffic lights. */
.desktop-app [data-slot='sidebar-container'],
.desktop-app [data-desktop-panel] {
border-right-width: 0;
}

.desktop-app [data-slot='sidebar-inner'],
.desktop-app [data-desktop-panel] {
position: relative;
}

.desktop-app [data-slot='sidebar-inner']::after,
.desktop-app [data-desktop-panel]::after {
position: absolute;
top: var(--desktop-title-bar-height);
right: 0;
bottom: 0;
width: 1px;
background: var(--sidebar-border);
content: '';
pointer-events: none;
}

/* Zoom can move the 800px desktop window into the responsive layout. Keep its floating menu and
any left-side sheet below the traffic lights and drag surface too. */
.desktop-app [data-desktop-floating-control] {
Expand Down
Loading