Repository navigation
move back and forward into the desktop app's title bar - #208
Merged
Merged
Conversation
…in-page back arrows
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The desktop app's window has no browser controls, so each detail page carried its own back arrow, hard-wired to a fixed list page rather than to wherever you came from. This puts back and forward buttons in the macOS title bar beside the traffic lights, with ⌘[ / ⌘] and the mouse's side buttons doing the same, and removes the in-page arrows everywhere: in the browser, its own back button covers it.
The buttons step through the window's real history using the Navigation API, which only counts the app's own pages, so going back never lands on the desktop app's sign-in or offline screens. With the arrows gone,
lib/back.tsand the back state the activity timelines handed to task pages are deleted too. Nothing changes inpackages/desktop, so this reaches the app with the next web deploy.Open workspace in Conductor