Skip to content

label the agent's right-click menu item edit instead of rename #228

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
hkonsti wants to merge 1 commit into
base: main
Choose a base branch
from
Open

label the agent's right-click menu item edit instead of rename #228

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions packages/web/src/pages/chat-page.test.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -189,7 +189,7 @@ describe('ChatPage', () => {
});
});

test('renames a changeable agent from its right-click menu', async () => {
test('edits a changeable agent from its right-click menu', async () => {
fetchMock.mockImplementation((_input, init) => {
if (init?.method === 'PUT') {
return Promise.resolve(Response.json({persona: {...finance, name: 'Accounting'}}));
Expand All @@ -199,7 +199,7 @@ describe('ChatPage', () => {
renderChatPage();

fireEvent.contextMenu(await screen.findByRole('link', {name: /Finance/}));
fireEvent.click(await screen.findByRole('menuitem', {name: 'Rename'}));
fireEvent.click(await screen.findByRole('menuitem', {name: 'Edit'}));
expect(screen.getByRole('heading', {name: 'Edit agent'})).toBeDefined();
expect(
screen.getByText('Its name and its head. The conversation stays as it is.'),
Expand Down Expand Up @@ -241,7 +241,7 @@ describe('ChatPage', () => {

fireEvent.contextMenu(await screen.findByRole('link', {name: /General/}));

expect(screen.queryByRole('menuitem', {name: 'Rename'})).toBeNull();
expect(screen.queryByRole('menuitem', {name: 'Edit'})).toBeNull();
expect(screen.queryByRole('menuitem', {name: 'Delete'})).toBeNull();
});

Expand Down
2 changes: 1 addition & 1 deletion packages/web/src/pages/chat-page.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -237,7 +237,7 @@ function PersonaList({
<ContextMenuContent>
<ContextMenuItem onClick={() => onEdit(persona)}>
<PencilIcon />
Rename
Edit
</ContextMenuItem>
<ContextMenuItem variant="destructive" onClick={() => onDelete(persona)}>
<Trash2Icon />
Expand Down
Loading