ci: bump actions/upload-pages-artifact from 3 to 5 - #7
Open
dependabot[bot] wants to merge 4 commits into
Open
Conversation
The prefix was doing the schema's job. pgraft_get_cluster_status() said
pgraft twice and still left the whole extension sitting in public, next to
everything else in the database. So the prefix goes and the schema takes
over: 34 functions, 19 views and 3 tables, none of them in public any
more.
pgraft.get_cluster_status() pgraft.get_nodes()
pgraft.add_node() pgraft.member_list
Signatures and result columns are untouched, so a caller only has to
rewrite the name. One view had to be renamed outright: pgraft_kv_status
would have landed on pgraft.kv_status, which the etcd-style summary view
already occupies, so the key/value store's own health view is now
pgraft.kv_store_status.
The upgrade script has to clear out what 1.0 created, and the order
matters: views come down in reverse creation order so each one goes
before the view it selects from, then the functions. No CASCADE anywhere
-- if an object of yours depends on a pgraft function, the upgrade should
stop and tell you, not drop your object on the way past.
The apply path executes SQL of its own, so pgraft_json.c had to move with
it, or replicated writes would have started failing the moment the
extension was upgraded.
The SQL reference had drifted. set_debug, log_append, kv_list_keys, kv_put_local and kv_delete_local were all documented returning something they do not return, and four of the table-returning functions listed columns that no longer exist anywhere -- get_queue_status was documented as pending_msgs/processed_msgs/queue_full, which is not close to what it actually gives you. Every signature on that page now matches the SQL, and the 19 views, none of which were documented at all, are on it too. The version requirements disagreed with themselves and with the build. go.mod has needed Go 1.23 since the etcd/raft v3.6 bump, while the badge said 1.21 and one page still said 1.15. The README claimed PostgreSQL 14 through 18 while four pages under docs/ demanded 17 or 18. The code has carried a pre-15 path all along, so 14 is right and CI now proves it.
Nothing built or tested pgraft on a push. The workflows that existed package releases and publish docs, both on workflow_dispatch, so a broken SQL script or a compile error could sit on main indefinitely. CI now builds against PostgreSQL 14 through 18 on every push and then does what a compile cannot: creates the extension, checks that no object escaped the pgraft schema, and selects from every view. That last check is what would have caught the drop-order bug in the upgrade script. The rest is scaffolding that was missing. CODE_OF_CONDUCT.md and SUPPORT.md say how to behave here and where to take a question; the issue and pull-request templates ask for the cluster state that makes a report actionable; CODEOWNERS routes review; dependabot watches both the pinned actions and the Go module; .editorconfig and .gitattributes keep whitespace and line endings from drifting between contributors.
Bumps [actions/upload-pages-artifact](https://github.com/actions/upload-pages-artifact) from 3 to 5. - [Release notes](https://github.com/actions/upload-pages-artifact/releases) - [Commits](actions/upload-pages-artifact@v3...v5) --- updated-dependencies: - dependency-name: actions/upload-pages-artifact dependency-version: '5' dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com>
Author
LabelsThe following labels could not be found: Please fix the above issues or remove invalid values from |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bumps actions/upload-pages-artifact from 3 to 5.
Release notes
Sourced from actions/upload-pages-artifact's releases.
Commits
fc324d3Merge pull request #139 from Tom-van-Woudenberg/patch-1fe9d4b7Merge branch 'main' into patch-10ca1617Merge pull request #137 from jonchurch/include-hidden-files57f0e84Update action.yml4a90348v7 --> hash56f665aUpdate upload-artifact action to version 7f7615f5Addinclude-hidden-filesinput7b1f4a7Merge pull request #127 from heavymachinery/pin-sha4cc19c7Pinactions/upload-artifactto SHA2d163beMerge pull request #107 from KittyChiu/mainDependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot show <dependency name> ignore conditionswill show all of the ignore conditions of the specified dependency@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)