Skip to content

fix(ui): ship the nav branding slot empty #3236

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
abose wants to merge 2 commits into
base: main
Choose a base branch
from
+6 −4
Open

fix(ui): ship the nav branding slot empty #3236

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9ae81a4
fix(ui): ship the nav branding slot empty
abose Sep 28, 2026
935efe4
chore: update pro deps
abose Sep 28, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions src/index.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -922,10 +922,12 @@
<div id="newProject" class="new-project-btn btn-alt-quiet"></div>
</div>
<div>
<!-- placeholder only: profile-menu.js _updateBranding repaints this once entitlements
resolve - localized "Get Phoenix Pro" for free users, plan name for pro users -->
<!-- Deliberately empty: profile-menu.js fills this once it knows what belongs
here - the plan name for pro users, localized "Get Phoenix Pro" for free
ones. Anything shipped here would be a guess made before entitlements
resolve, and it would be shown to every user including the paying ones. -->
<a id="phcode-io-main-nav" href="https://phcode.dev/pricing?promo=FreeNavbar"

Check warning on line 929 in src/index.html

View check run for this annotation

SonarQubeCloud / SonarCloud Code Analysis

Anchors must have content and the content must be accessible by a screen reader. 


See more on https://sonarcloud.io/project/issues?id=phcode-dev_phoenix&issues=AaDopNRhlacU-vKY9tYN&open=AaDopNRhlacU-vKY9tYN&pullRequest=3236
target="_blank" rel="noopener">phcode.dev</a>
target="_blank" rel="noopener"></a>
</div>
<div id="mainNavBarRight">
<div id="navBackButton" class="nav-back-btn btn-alt-quiet"><i class="fa-solid fa-arrow-left"></i></div>
Expand Down
2 changes: 1 addition & 1 deletion tracking-repos.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
{
"phoenixPro": {
"commitID": "e36ebad4a751c32f66bae7d28b638124da68e1e2"
"commitID": "69b4233ff170f6e380aa7b3d2a8f09da6ee12b35"
}
}
Loading