Add Windows installer strings for translation - #3239
Open
devvaannsh wants to merge 1 commit into
Open
devvaannsh wants to merge 1 commit into
devvaannsh wants to merge 1 commit into
Conversation
devvaannsh
force-pushed
the
installer-translations
branch
from
September 29, 2026 14:34
dba4f7f to
7ae96aa
Compare
|
Member
|
Since we are in the release phase, this is a risky change to do for a release planned to go next week. so deferring till the nov-december release. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Please refer to this issue: #3238
Phoenix Desktop related PR: phcode-dev/phoenix-desktop#746
On Windows, some installer screens show up blank in many languages as the installer framework that we use only has support for few languages. So now we add all the installer related strings to Phoenix repo's
nls/root/strings.jsfile and then phoenix-desktop references those strings.