Repository navigation
Raise the package validation baseline to 0.9.0 - #53
Merged
Merged
Conversation
0.9.0 is published, so package validation now compares against it and the APIs added in that release are protected too (docs/versioning.md). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Raises
PackageValidationBaselineVersioninsrc/Directory.Build.propsfrom 0.8.1 to 0.9.0. 0.9.0 is published on nuget.org, so package validation now compares against it and the APIs added in that release are protected too (docs/versioning.md). There are noCompatibilitySuppressions.xmlfiles to remove.dotnet pack -c Releasepasses package validation for EncDotNet.Iso8211, EncDotNet.S57 and EncDotNet.Noaa against the published 0.9.0 packages (net8.0 and net10.0). So everything merged since v0.9.0 (#43–#48, #50–#52) is additive.Standards alignment
Check each area this PR touches and confirm the matching skill was consulted
(
.github/skills/<name>/SKILL.md):iso8211)s57-enc)chart-viewer)Standard section references cited in code or docs:
None.
Tests
tests/dotnet test --configuration Releasepasses locallyEncDotNet.UnitTests passes locally (1091 passed, 1 skipped). Three retained-memory budget tests in EncDotNet.PerformanceTests fail locally (
S57Document,S57Chart,Iso8211Document). They fail the same way on unmodifiedmain, andmain's CI passed, so this machine's environment causes them, not this change.Documentation
src/<project>/README.mddocs/if user-facing behavior changeddocfx docfx.json --warningsAsErrorspasses, if docs changedDependencies
Directory.Packages.props(not in the.csproj)gh-advisory-databasesecurity check run for any new dependencyBreaking changes
None
🤖 Generated with Claude Code