Repository navigation
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #115.
The street address pattern joined its parts with
\s, so a match could span lines: in the issue's example,50613\n\nDear Drwas detected as an address. The parts are now joined by[ \t]+, the same change as the Java fix in philterd/phileas#477, so a match stays on one line.Tests cover the reproduction (one match,
214 Juniper Court), the ZIP and greeting lines joined by\nand by\r\n, a number and a street type on different lines, and multi-line address blocks where the street line is still found, including one with a unit. The reproduction test and the three new negative cases fail on main. The full suite passes (2399 passed, the model download e2e test not run).One difference from before: Python's
\salso matched a no-break space and other Unicode spaces, so123andMain Streetjoined by a no-break space (U+00A0) was detected and now is not, as in Java. If you'd rather keep those,[^\S\r\n]would do it; I kept[ \t]because the issue asks for Java's behavior.AI assistance (Claude Code) was used for this change.