Repository navigation
Support doctrine/dbal 4.5 next to 4.4 - #31
Merged
Merged
Conversation
DBAL 4.5 deprecates Column::getType() and passing a Type instance to the Column constructor, and resolves an instance's name by identity in the type registry, so a fresh GuidType is no longer registered. 4.4 has neither getTypeName() nor string type names, so Table picks the API at runtime and the tests use registered instances. Psalm 6.20 reports the nullsafe call in Vector as possibly null while 6.14 calls a null fallback redundant, so Vector uses a plain ternary.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CI resolves fresh dependencies and now picks up doctrine/dbal 4.5.0 and psalm 6.20.0, which breaks main as well as open PRs such as #30.
DBAL 4.5 deprecates
Column::getType()and passing aTypeinstance to theColumnconstructor, and it resolves an instance's name by identity in the type registry, so tests that built columns withnew GuidType()now throwTypeNotRegistered. Because 4.4 has neithergetTypeName()nor string type names,Tablepicks the available API at runtime instead of raising the constraint to ^4.5. The tests use the registered instances fromType::getType(), like the other tests already do.Psalm 6.20 reports the nullsafe call in
Vectoras possibly null, while 6.14 reports a null fallback there as redundant, soVectoruses a plain ternary that both versions accept.The
typeOf()helper inTablecan go once the constraint moves to ^4.5.