What is changed, added or deleted? (Required)
The "Store Query Feedback QPS" panel description reads:
- Store Query Feedback QPS: the number of operations per second to store the feedback information of the union query, which is performed in TiDB memory
While translating this into Japanese, I tried to verify the meaning of "union query" here (does it refer to SQL's UNION operator specifically, or something else?) and could not confirm it against available sources:
- The actual Grafana dashboard JSON (
pingcap/monitoring, e.g. monitor/v4.0.0-beta.2/dashboards/tidb.json, panel id 170) has a much simpler built-in description: "TiDB store quering feedback counts" — no mention of "union" at all. Its query is sum(rate(tidb_statistics_store_query_feedback_total[1m])) by (type).
- The Chinese source (
docs-cn/grafana-tidb-dashboard.md) uses "合并查询" (roughly "merged/combined query"), which is a different concept from SQL UNION.
- Searching TiDB source for the underlying
StoreQueryFeedbackCounter metric (session.StoreQueryFeedback) shows the type label used is just ok/error (success/failure of storing feedback), with no reference to "union" or "merge" query semantics.
Given (1) and (3), it's unclear whether "union query" is accurate, and if so, what it's meant to convey (this statistics-feedback mechanism may be legacy/deprecated, since the underlying metric/counter doesn't appear to exist in current pingcap/tidb master). Could someone with more context on the statistics feedback mechanism confirm whether "union query" is accurate here, and if not, suggest a corrected description?
Which TiDB version(s) do your changes apply to? (Required)
What is the related PR or file link(s)?
Do your changes match any of the following descriptions?
What is changed, added or deleted? (Required)
The "Store Query Feedback QPS" panel description reads:
While translating this into Japanese, I tried to verify the meaning of "union query" here (does it refer to SQL's
UNIONoperator specifically, or something else?) and could not confirm it against available sources:pingcap/monitoring, e.g.monitor/v4.0.0-beta.2/dashboards/tidb.json, panel id 170) has a much simpler built-in description:"TiDB store quering feedback counts"— no mention of "union" at all. Its query issum(rate(tidb_statistics_store_query_feedback_total[1m])) by (type).docs-cn/grafana-tidb-dashboard.md) uses "合并查询" (roughly "merged/combined query"), which is a different concept from SQLUNION.StoreQueryFeedbackCountermetric (session.StoreQueryFeedback) shows thetypelabel used is justok/error(success/failure of storing feedback), with no reference to "union" or "merge" query semantics.Given (1) and (3), it's unclear whether "union query" is accurate, and if so, what it's meant to convey (this statistics-feedback mechanism may be legacy/deprecated, since the underlying metric/counter doesn't appear to exist in current
pingcap/tidbmaster). Could someone with more context on the statistics feedback mechanism confirm whether "union query" is accurate here, and if not, suggest a corrected description?Which TiDB version(s) do your changes apply to? (Required)
What is the related PR or file link(s)?
Do your changes match any of the following descriptions?