Skip to content

migrate-from-mysql-using-aws-dms: fix "test" mislabeled as a system database - #23700

Merged
ti-chi-bot[bot] merged 3 commits into
pingcap:release-8.5from
yahonda:fix-en-test-not-system-db
Sep 7, 2026
Merged

migrate-from-mysql-using-aws-dms: fix "test" mislabeled as a system database#23700
ti-chi-bot[bot] merged 3 commits into
pingcap:release-8.5from
yahonda:fix-en-test-not-system-db

Conversation

@yahonda

@yahonda yahonda commented Sep 2, 2026

Copy link
Copy Markdown
Member

What is changed, added or deleted? (Required)

The doc listed test alongside INFORMATION_SCHEMA, PERFORMANCE_SCHEMA, mysql, and sys under the label "system databases". test is a default user database TiDB/MySQL creates for convenience, not a system (metadata) database like the other four. Reworded the shared label to "default databases", which accurately covers all five entries without changing the practical guidance (still filter out all five when setting up an AWS DMS migration task).

Which TiDB version(s) do your changes apply to? (Required)

  • master (the latest development version)
  • v8.5 (LTS)

Do your changes match any of the following descriptions? (Required)

  • Delete files in the markdown-pages repository
  • Change the directory
  • Need modification after machine translation
  • Screenshots or GIFs are included in the changes

Summary by CodeRabbit

  • Documentation
    • Updated the AWS DMS migration guide to recommend explicitly selecting only the databases and tables intended for migration.
    • Clarified that using the default % wildcard may include MySQL system databases and cause the migration task to fail.

…atabase

`test` is a default user database, not a system database (unlike
INFORMATION_SCHEMA, PERFORMANCE_SCHEMA, mysql, and sys). Reword to
"default databases" so the list's shared label is accurate for all
five entries.

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
@ti-chi-bot

ti-chi-bot Bot commented Sep 2, 2026

Copy link
Copy Markdown

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@ti-chi-bot ti-chi-bot Bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 2, 2026
@coderabbitai

coderabbitai Bot commented Sep 2, 2026

Copy link
Copy Markdown

Review Change Stack

Note

Reviews paused

It looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the reviews.auto_review.auto_pause_after_reviewed_commits setting.

Use the following commands to manage reviews:

  • @coderabbitai resume to resume automatic reviews.
  • @coderabbitai review to trigger a single review.

Use the checkboxes below for quick actions:

  • ▶️ Resume reviews
  • 🔍 Trigger review

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Team

Run ID: 2398ed6a-97b5-4f9f-8235-338662218582

📥 Commits

Reviewing files that changed from the base of the PR and between 1e4196d and b4e5b78.

📒 Files selected for processing (1)
  • tidb-cloud/migrate-from-mysql-using-aws-dms.md

Included review availability: Your plan provides up to 4 included reviews per hour; 2 remain after this review.


📝 Walkthrough

Walkthrough

The AWS DMS migration guide now instructs users to select only the databases and tables they want to migrate. It warns that the default % wildcard can include MySQL system databases and cause the migration task to fail.

Changes

AWS DMS documentation

Layer / File(s) Summary
Migration task selection guidance
tidb-cloud/migrate-from-mysql-using-aws-dms.md
Updates the prerequisite to recommend explicit database and table selection. The guidance lists system databases that the % wildcard might migrate and identifies possible task failure.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Merge Risk: 🔵 Low · up to b4e5b

The AWS DMS guide changes database-selection guidance, but an unresolved terminology inconsistency could confuse users about which default databases must be excluded. Resolve the wording before merge.

Suggested reviewers: qiancai

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly identifies the main documentation change: correcting the classification of test as a system database.
Description check ✅ Passed The description explains the change, its rationale, affected TiDB versions, and applicable change categories. It omits some optional template sections, but the required information is complete.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@ti-chi-bot ti-chi-bot Bot added missing-translation-status This PR does not have translation status info. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Sep 2, 2026
@yahonda
yahonda marked this pull request as ready for review September 2, 2026 05:51
@ti-chi-bot ti-chi-bot Bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 2, 2026
Comment thread tidb-cloud/migrate-from-mysql-using-aws-dms.md Outdated
@qiancai qiancai self-assigned this Sep 3, 2026
@qiancai qiancai added the translation/doing This PR's assignee is translating this PR. label Sep 3, 2026
@ti-chi-bot ti-chi-bot Bot removed the missing-translation-status This PR does not have translation status info. label Sep 3, 2026
@qiancai qiancai added needs-cherry-pick-master Should cherry pick this PR to master branch. missing-translation-status This PR does not have translation status info. and removed missing-translation-status This PR does not have translation status info. labels Sep 3, 2026
Co-authored-by: Grace Cai <qqzczy@126.com>

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1


ℹ️ Review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Team

Run ID: 5fc413b9-6e2e-4ed6-83ba-b32ecad31cc2

📥 Commits

Reviewing files that changed from the base of the PR and between 7b48fb9 and 1e4196d.

📒 Files selected for processing (1)
  • tidb-cloud/migrate-from-mysql-using-aws-dms.md

Included review availability: Your plan provides up to 4 included reviews per hour; 2 remain after this review.

Comment thread tidb-cloud/migrate-from-mysql-using-aws-dms.md Outdated
Comment thread tidb-cloud/migrate-from-mysql-using-aws-dms.md Outdated
@qiancai

qiancai commented Sep 7, 2026

Copy link
Copy Markdown
Collaborator

/approve

@qiancai qiancai added the lgtm label Sep 7, 2026
@ti-chi-bot

ti-chi-bot Bot commented Sep 7, 2026

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: qiancai

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot Bot added the approved label Sep 7, 2026
@ti-chi-bot
ti-chi-bot Bot merged commit 94afa8e into pingcap:release-8.5 Sep 7, 2026
12 checks passed
@ti-chi-bot

Copy link
Copy Markdown
Member

In response to a cherrypick label: new pull request created to branch master: #23756.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved lgtm needs-cherry-pick-master Should cherry pick this PR to master branch. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. translation/doing This PR's assignee is translating this PR.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants