migrate-from-mysql-using-aws-dms: fix "test" mislabeled as a system database - #23700
Conversation
…atabase `test` is a default user database, not a system database (unlike INFORMATION_SCHEMA, PERFORMANCE_SCHEMA, mysql, and sys). Reword to "default databases" so the list's shared label is accurate for all five entries. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
|
Skipping CI for Draft Pull Request. |
|
Note Reviews pausedIt looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the Use the following commands to manage reviews:
Use the checkboxes below for quick actions:
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Team Run ID: 📒 Files selected for processing (1)
Included review availability: Your plan provides up to 4 included reviews per hour; 2 remain after this review. 📝 WalkthroughWalkthroughThe AWS DMS migration guide now instructs users to select only the databases and tables they want to migrate. It warns that the default ChangesAWS DMS documentation
Estimated code review effort: 1 (Trivial) | ~2 minutes Merge Risk: 🔵 Low · up to The AWS DMS guide changes database-selection guidance, but an unresolved terminology inconsistency could confuse users about which default databases must be excluded. Resolve the wording before merge. Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Co-authored-by: Grace Cai <qqzczy@126.com>
There was a problem hiding this comment.
Actionable comments posted: 1
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: ASSERTIVE
Plan: Team
Run ID: 5fc413b9-6e2e-4ed6-83ba-b32ecad31cc2
📒 Files selected for processing (1)
tidb-cloud/migrate-from-mysql-using-aws-dms.md
Included review availability: Your plan provides up to 4 included reviews per hour; 2 remain after this review.
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: qiancai The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
In response to a cherrypick label: new pull request created to branch |
What is changed, added or deleted? (Required)
The doc listed
testalongsideINFORMATION_SCHEMA,PERFORMANCE_SCHEMA,mysql, andsysunder the label "system databases".testis a default user database TiDB/MySQL creates for convenience, not a system (metadata) database like the other four. Reworded the shared label to "default databases", which accurately covers all five entries without changing the practical guidance (still filter out all five when setting up an AWS DMS migration task).Which TiDB version(s) do your changes apply to? (Required)
Do your changes match any of the following descriptions? (Required)
markdown-pagesrepositorySummary by CodeRabbit
%wildcard may include MySQL system databases and cause the migration task to fail.