sql: remove unnecessary 'copy' from FLUSH PRIVILEGES description (#23196) - #23753
sql: remove unnecessary 'copy' from FLUSH PRIVILEGES description (#23196)#23753ti-chi-bot wants to merge 1 commit into
Conversation
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
|
@yahonda This PR has conflicts, I have hold it. |
|
@ti-chi-bot: ## If you want to know how to resolve it, please read the guide in TiDB Dev Guide. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
📝 WalkthroughWalkthroughThe change rewords the ChangesFLUSH PRIVILEGES documentation
Estimated code review effort: 2 (Simple) | ~10 minutes Merge Risk: 🟡 Moderate · up to The documentation update would publish unresolved merge-conflict text and duplicate the account-management statement table, leaving users with malformed and inconsistent SQL reference content. Resolve the conflict and retain one updated table before merging. Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches 💡 1🛠️ Fix failing CI checks 💡
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
@ti-chi-bot: The following test failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
There was a problem hiding this comment.
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
sql-statements/sql-statement-overview.md (1)
274-314: 🎯 Functional Correctness | 🟠 Major | ⚡ Quick winResolve the merge conflict before merging.
The
<<<<<<< HEAD,=======, and>>>>>>>markers remain in the document. The file also contains two competing Account management tables. Remove the conflict markers and retain one table with the updatedFLUSH PRIVILEGESdescription.| SQL Statement | Description | | --------------------------------------------------------------------------- | ------------------------------------------------------------------- | | [`ALTER USER`](/sql-statements/sql-statement-alter-user.md) | Modifies a user. | | [`CREATE ROLE`](/sql-statements/sql-statement-create-role.md) | Creates a role. | | [`CREATE USER`](/sql-statements/sql-statement-create-user.md) | Creates a new user. | | [`DROP ROLE`](/sql-statements/sql-statement-drop-role.md) | Drops an existing role. | | [`DROP USER`](/sql-statements/sql-statement-drop-user.md) | Drops an existing user. | | [`FLUSH PRIVILEGES`](/sql-statements/sql-statement-flush-privileges.md) | Refreshes the in-memory privilege cache from the privilege tables. | | [`GRANT <privileges>`](/sql-statements/sql-statement-grant-privileges.md) | Grants privileges. | | [`GRANT <role>`](/sql-statements/sql-statement-grant-role.md) | Grants a role. | | [`RENAME USER`](/sql-statements/sql-statement-rename-user.md) | Renames an existing user. | | [`REVOKE <privileges>`](/sql-statements/sql-statement-revoke-privileges.md) | Revokes privileges. | | [`REVOKE <role>`](/sql-statements/sql-statement-revoke-role.md) | Revokes a role. | | [`SET DEFAULT ROLE`](/sql-statements/sql-statement-set-default-role.md) | Sets a default role. | | [`SET PASSWORD`](/sql-statements/sql-statement-set-password.md) | Changes a password. | | [`SET ROLE`](/sql-statements/sql-statement-set-role.md) | Enables roles in the current session. | | [`SHOW CREATE USER`](/sql-statements/sql-statement-show-create-user.md) | Shows the `CREATE` statement for a user. | | [`SHOW GRANTS`](/sql-statements/sql-statement-show-grants.md) | Shows privileges associated with a user. | | [`SHOW PRIVILEGES`](/sql-statements/sql-statement-show-privileges.md) | Shows available privileges. |As per path instructions: provide a committable suggestion for contiguous Markdown fixes.
Source: Path instructions
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: ASSERTIVE
Plan: Team
Run ID: 6ea6790a-b172-4e2d-835b-5ecf6c5c59b8
📒 Files selected for processing (2)
sql-statements/sql-statement-flush-privileges.mdsql-statements/sql-statement-overview.md
Included review availability: Your plan provides up to 4 included reviews per hour; 2 remain after this review.
This is an automated cherry-pick of #23196
What is changed, added or deleted? (Required)
Align the
FLUSH PRIVILEGESdescription with MySQL documentation. Changed:reload the in-memory copy of privileges from the privilege tablesreload the grant tables into memoryMySQL's own documentation at https://dev.mysql.com/doc/refman/8.4/en/privilege-changes.html uses
reload the grant tableswithoutcopy. TiDB documentation should follow the same concise style.Which TiDB version(s) do your changes apply to? (Required)
What is the related PR or file link(s)?
Do your changes match any of the following descriptions?
Summary by CodeRabbit
FLUSH PRIVILEGES, including how privileges are refreshed from privilege tables.