i18n(ja): fix particles/punctuation trapped inside bold spans across corpus - #23765
i18n(ja): fix particles/punctuation trapped inside bold spans across corpus#23765yahonda wants to merge 2 commits into
Conversation
…ch EN bold boundaries
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
📝 WalkthroughWalkthroughThis documentation-only change corrects Japanese wording, punctuation, and Markdown emphasis across benchmark, TiDB, DM, TiDB Cloud, troubleshooting, and release documents. It changes no public entities or software behavior. ChangesJapanese documentation corrections
Estimated code review effort: 2 (Simple) | ~10 minutes Change: Other Merge Risk: 🔵 Low · up to The Japanese phantom-read example may mislead readers about why a repeated query returns additional rows. Clarifying that modified rows become query matches would make the documented behavior accurate before merge. Possibly related PRs
Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches 💡 1🛠️ Fix failing CI checks 💡
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 3
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: ASSERTIVE
Plan: Team
Run ID: 09b4d5bb-0244-4ced-a6fe-8930a28ec9d0
📒 Files selected for processing (36)
benchmark/online-workloads-and-add-index-operations.mdbenchmark/v4.0-performance-benchmarking-with-tpch.mddeploy-monitoring-services.mddevelop/dev-guide-aws-appflow-integration.mddevelop/dev-guide-create-table.mddevelop/dev-guide-tidb-basics.mddevelop/dev-guide-timeouts-in-tidb.mddevelop/dev-guide-transaction-restraints.mddm/dm-glossary.mddm/dm-replication-logic.mddm/dm-webui-guide.mddumpling-overview.mdexternal-storage-uri.mdinformation-schema/information-schema-deadlocks.mdreleases/release-7.0.0.mdreleases/release-8.5.4.mdruntime-filter.mdtidb-cloud/branch-manage.mdtidb-cloud/changefeed-sink-to-apache-kafka.mdtidb-cloud/changefeed-sink-to-apache-pulsar.mdtidb-cloud/data-service-manage-data-app.mdtidb-cloud/essential-changefeed-sink-to-kafka.mdtidb-cloud/migrate-from-mysql-using-data-migration.mdtidb-cloud/migrate-incremental-data-from-mysql-using-data-migration.mdtidb-cloud/releases/release-notes-2023.mdtidb-cloud/releases/tidb-cloud-release-notes.mdtidb-cloud/serverless-private-link-connection-to-amazon-msk.mdtidb-cloud/set-up-private-endpoint-connections-on-alibaba-cloud.mdtidb-cloud/set-up-private-endpoint-connections-on-azure.mdtidb-cloud/size-your-cluster.mdtidb-cloud/tidb-cloud-auditing.mdtidb-cloud/tidb-x-architecture.mdtidb-cloud/top-ru.mdtidb-troubleshooting-map.mdtroubleshoot-write-conflicts.mdtune-tikv-thread-performance.md
Included review availability: Your plan provides up to 4 included reviews per hour; 1 remains after this review.
Address CodeRabbit review comments on PR pingcap#23765. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
There was a problem hiding this comment.
Actionable comments posted: 1
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: ASSERTIVE
Plan: Advanced
Run ID: 18a198f4-404b-4706-973b-790e8474b340
📒 Files selected for processing (3)
develop/dev-guide-transaction-restraints.mddm/dm-replication-logic.mdtidb-cloud/branch-manage.md
Included review availability: Your plan provides up to 4 included reviews per hour; 0 remain after this review.
What is changed, added or deleted? (Required)
Corpus-wide fix for a bold-span markup defect: a Japanese grammatical particle (が/を/に/は/も/と/etc.), sometimes with trailing punctuation, was trapped inside the closing
**of a bold span instead of falling outside it, where EN's own bold boundary ends. This was found while manually reviewing a specific instance inbest-practices/ddl-introduction.md, then swept across the wholei18n-ja-release-8.5corpus by pattern-matching bold spans ending in a particle and verifying each candidate against the EN source (release-8.5) before fixing.36 files, 58 sites fixed. Only the
**marker position was moved in each case — no wording or translation content was changed. Several dozen additional candidates were reviewed and left untouched because they were false positives (particle is part of a fixed grammatical construction like〜しないでください, or EN's own bold scope genuinely includes the trailing word).Which TiDB version(s) do your changes apply to? (Required)
What is the related PR or file link(s)?
AI agent involvement
Do your changes match any of the following descriptions?
Summary by CodeRabbit