Skip to content

i18n(ja): fix dropped particles and unclosed parenthesis found by CodeRabbit - #23782

Open
yahonda wants to merge 2 commits into
pingcap:i18n-ja-release-8.5from
yahonda:fix-dropped-particles-coderabbit-23778
Open

i18n(ja): fix dropped particles and unclosed parenthesis found by CodeRabbit#23782
yahonda wants to merge 2 commits into
pingcap:i18n-ja-release-8.5from
yahonda:fix-dropped-particles-coderabbit-23778

Conversation

@yahonda

@yahonda yahonda commented Sep 9, 2026

Copy link
Copy Markdown
Member

What is changed, added or deleted? (Required)

Fixes 3 defect classes found by CodeRabbit on PR #23778 (zero-width-space removal) that were unrelated to that PR's scope, split here to keep that diff focused:

  1. Missing を particle before the .env/env.sh destination file name in the "copy and paste the corresponding connection string" step instruction, shared across 14 develop/dev-guide-sample-application-*.md pages + develop/dev-guide-wordpress.md (48 sites total -- CodeRabbit flagged only 1 site, a corpus grep for the identical shared template sentence found the same defect repeated across all sibling guide pages using this instruction).
  2. tidb-cloud/tidbx-instance-move-faq.md: unclosed parenthesis around a support-contact mailto link.
  3. tiproxy/tiproxy-configuration.md: missing と particle before 組み合わせて使用できます.

Which TiDB version(s) do your changes apply to? (Required)

  • i18n-ja-release-8.5 (TiDB Japanese documentation for TiDB 8.5 versions)

What is the related PR or file link(s)?

AI agent involvement

  • The changes in this PR were primarily made by an AI agent on behalf of the PR author.

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

Summary by CodeRabbit

  • Documentation
    • Corrected Japanese grammar and removed invisible-character typos in connection setup instructions across multiple language and framework guides.
    • Clarified directions for copying connection strings into .env and env.sh files.
    • Fixed Japanese wording in the WordPress and TiProxy configuration guides.
    • Corrected malformed Markdown syntax in the TiDBX instance move FAQ.

…eRabbit

Found on PR pingcap#23778 (zero-width-space removal), but unrelated to that
fix's scope, so applied here as a separate PR per the user's request to
keep the ZWSP diff easy to read.

- 14 dev-guide-sample-application-*.md + dev-guide-wordpress.md: missing
  を particle before the .env/env.sh destination file in the 'copy and
  paste the corresponding connection string' step instruction. CodeRabbit
  flagged only 1 site (nextjs.md); a corpus grep for the identical shared
  template sentence found the same defect repeated across 13 more sibling
  guide pages sharing this instruction (48 sites total).
- tidb-cloud/tidbx-instance-move-faq.md: unclosed parenthesis around the
  support-contact mailto link.
- tiproxy/tiproxy-configuration.md: missing と particle before
  '組み合わせて使用できます'.

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
@ti-chi-bot

ti-chi-bot Bot commented Sep 9, 2026

Copy link
Copy Markdown

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@ti-chi-bot ti-chi-bot Bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 9, 2026
@coderabbitai

coderabbitai Bot commented Sep 9, 2026

Copy link
Copy Markdown

Review Change StackReview Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Advanced

Run ID: dd5a9ba5-8c27-4fd3-892f-a3d998898ac0

📥 Commits

Reviewing files that changed from the base of the PR and between a2da298 and 3cb307e.

📒 Files selected for processing (16)
  • develop/dev-guide-sample-application-golang-gorm.md
  • develop/dev-guide-sample-application-golang-sql-driver.md
  • develop/dev-guide-sample-application-java-hibernate.md
  • develop/dev-guide-sample-application-java-jdbc.md
  • develop/dev-guide-sample-application-java-mybatis.md
  • develop/dev-guide-sample-application-java-spring-boot.md
  • develop/dev-guide-sample-application-nextjs.md
  • develop/dev-guide-sample-application-python-django.md
  • develop/dev-guide-sample-application-python-mysql-connector.md
  • develop/dev-guide-sample-application-python-mysqlclient.md
  • develop/dev-guide-sample-application-python-peewee.md
  • develop/dev-guide-sample-application-python-pymysql.md
  • develop/dev-guide-sample-application-python-sqlalchemy.md
  • develop/dev-guide-wordpress.md
  • tidb-cloud/tidbx-instance-move-faq.md
  • tiproxy/tiproxy-configuration.md

Included review availability: Your plan provides up to 4 included reviews per hour; 1 remains after this review.


📝 Walkthrough

Walkthrough

The pull request corrects Japanese wording and invisible-character issues in connection instructions across sample application guides. It also fixes one malformed Markdown link and one TiProxy documentation phrase. No code or configuration changes are included.

Changes

Connection instruction corrections

Layer / File(s) Summary
Sample application connection instructions
develop/dev-guide-sample-application-*.md, develop/dev-guide-wordpress.md
Corrects Japanese connection-string instructions across Go, Java, Python, Next.js, and WordPress guides. The edits add missing particles and remove invisible characters.

FAQ link correction

Layer / File(s) Summary
Support link markup
tidb-cloud/tidbx-instance-move-faq.md
Closes the support mailto link with the missing Markdown bracket and parenthesis.

TiProxy wording correction

Layer / File(s) Summary
Virtual-IP description
tiproxy/tiproxy-configuration.md
Adds the missing Japanese conjunction in the virtual-ip description.

Priority: ⬇️ Low

Estimated code review effort: 1 (Trivial) | ~5 minutes

Merge Risk: ⚪ Minimal · up to 3cb30

This change corrects Japanese connection instructions, a support mailto link, and TiProxy wording without altering product behavior or configuration. No current merge-readiness risk remains.

Suggested reviewers: qiancai

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Description check ✅ Passed The description explains all three defect classes, identifies the affected files and scope, specifies the target documentation version, references the related PR, and records AI involvement. The optio…
Title check ✅ Passed The title clearly summarizes the Japanese localization fixes for dropped particles and an unclosed parenthesis. It is concise and related to the main changes.
✨ Finishing Touches 💡 1
🛠️ Fix failing CI checks 💡
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@ti-chi-bot ti-chi-bot Bot added the area/develop This PR relates to the area of TiDB App development. label Sep 9, 2026
@ti-chi-bot

ti-chi-bot Bot commented Sep 9, 2026

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign oreoxmt for approval. For more information see the Code Review Process.
Please ensure that each of them provides their approval before proceeding.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot Bot added missing-translation-status This PR does not have translation status info. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Sep 9, 2026
…his PR

PR pingcap#23778 (zero-width-space removal) touches the exact same lines this
PR already modifies for the missing-particle/parenthesis fix. Removing
the zero-width space here too avoids a same-line merge conflict
regardless of which PR merges first.

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
@yahonda
yahonda marked this pull request as ready for review September 9, 2026 00:47
@ti-chi-bot ti-chi-bot Bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 9, 2026
@qiancai qiancai added translation/no-need No need to translate this PR. and removed missing-translation-status This PR does not have translation status info. labels Sep 10, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/develop This PR relates to the area of TiDB App development. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. translation/no-need No need to translate this PR.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants