i18n(ja): fix dropped particles and word-order scramble in best-practices docs - #23790
i18n(ja): fix dropped particles and word-order scramble in best-practices docs#23790yahonda wants to merge 3 commits into
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
Warning Review limit reachedNext included review available in 17 minutes. View limit detailsLimit details: You’ve used all 4 included reviews currently available. You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Review configuration: ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Advanced Run ID: 📒 Files selected for processing (2)
📝 WalkthroughWalkthroughThe change corrects Japanese wording in three best-practices documents. It updates a figure description, two grammar errors, and UUID documentation wording, punctuation, and linking. ChangesJapanese documentation corrections
Priority: ⬇️ Low Estimated code review effort: 1 (Trivial) | ~3 minutes Severity of issue fixed: Low Merge Risk: 🔵 Low · up to The documentation changes correct Japanese wording, but the UUID example still describes the two insertions inconsistently, which may reduce clarity for readers. No runtime behavior or procedures are affected. Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches 💡 1🛠️ Fix failing CI checks 💡
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: ASSERTIVE
Plan: Advanced
Run ID: 111483f5-f55d-4009-b744-d709161ed4e3
📒 Files selected for processing (3)
best-practices/grafana-monitor-best-practices.mdbest-practices/multi-column-index-best-practices.mdbest-practices/uuid.md
Included review availability: Your plan provides up to 4 included reviews per hour; 2 remain after this review.
What is changed, added or deleted? (Required)
Fixes dropped particles and word-order scrambles found while sweeping best-practices docs for the same defect class found in performance-tuning-practices.md/methods.md: missing が/は/を particles immediately after backtick-quoted identifiers, and a missing enumeration item (three dimensions collapsed into a malformed fragment).
best-practices/grafana-monitor-best-practices.md: "three dimensions (instance,jobandtype)" had lost the "three dimensions" count and enumeration commas entirely.best-practices/multi-column-index-best-practices.md: 2 sites, missing が before comparison verbs (a1が1より大きい/小さい).best-practices/uuid.md: missing は before a UUID_TO_BIN usage clause, and missing を before 明示的に設定する.Which TiDB version(s) do your changes apply to? (Required)
What is the related PR or file link(s)?
AI agent involvement
Do your changes match any of the following descriptions?