Skip to content

i18n(ja): fix dropped particles and word-order scramble in best-practices docs - #23790

Open
yahonda wants to merge 3 commits into
pingcap:i18n-ja-release-8.5from
yahonda:fix-best-practices-particle-drops
Open

i18n(ja): fix dropped particles and word-order scramble in best-practices docs#23790
yahonda wants to merge 3 commits into
pingcap:i18n-ja-release-8.5from
yahonda:fix-best-practices-particle-drops

Conversation

@yahonda

@yahonda yahonda commented Sep 9, 2026

Copy link
Copy Markdown
Member

What is changed, added or deleted? (Required)

Fixes dropped particles and word-order scrambles found while sweeping best-practices docs for the same defect class found in performance-tuning-practices.md/methods.md: missing が/は/を particles immediately after backtick-quoted identifiers, and a missing enumeration item (three dimensions collapsed into a malformed fragment).

  • best-practices/grafana-monitor-best-practices.md: "three dimensions (instance, job and type)" had lost the "three dimensions" count and enumeration commas entirely.
  • best-practices/multi-column-index-best-practices.md: 2 sites, missing が before comparison verbs (a11より大きい/小さい).
  • best-practices/uuid.md: missing は before a UUID_TO_BIN usage clause, and missing を before 明示的に設定する.

Which TiDB version(s) do your changes apply to? (Required)

  • i18n-ja-release-8.5 (TiDB Japanese documentation for TiDB 8.5 versions)

What is the related PR or file link(s)?

  • This PR is translated from:
  • Other reference link(s):

AI agent involvement

  • The changes in this PR were primarily made by an AI agent on behalf of the PR author.

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

@ti-chi-bot

ti-chi-bot Bot commented Sep 9, 2026

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign oreoxmt for approval. For more information see the Code Review Process.
Please ensure that each of them provides their approval before proceeding.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot Bot added missing-translation-status This PR does not have translation status info. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Sep 9, 2026
@coderabbitai

coderabbitai Bot commented Sep 9, 2026

Copy link
Copy Markdown

Review Change StackReview Change Stack

Warning

Review limit reached

Next included review available in 17 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used all 4 included reviews currently available.

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Learn how review limits work.

Review configuration:

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Advanced

Run ID: 49c33d44-e851-417a-95de-bccde2723746

📥 Commits

Reviewing files that changed from the base of the PR and between a8066cf and 793eed8.

📒 Files selected for processing (2)
  • best-practices/grafana-monitor-best-practices.md
  • best-practices/uuid.md
📝 Walkthrough

Walkthrough

The change corrects Japanese wording in three best-practices documents. It updates a figure description, two grammar errors, and UUID documentation wording, punctuation, and linking.

Changes

Japanese documentation corrections

Layer / File(s) Summary
Best-practices wording corrections
best-practices/grafana-monitor-best-practices.md, best-practices/multi-column-index-best-practices.md, best-practices/uuid.md
Corrected the Grafana figure description, added missing Japanese particles in the multi-column index example, and updated UUID wording, punctuation, and the CLUSTERED option link. No technical behavior or procedure changed.

Priority: ⬇️ Low

Estimated code review effort: 1 (Trivial) | ~3 minutes

Severity of issue fixed: Low

Merge Risk: 🔵 Low · up to a8066

The documentation changes correct Japanese wording, but the UUID example still describes the two insertions inconsistently, which may reduce clarity for readers. No runtime behavior or procedures are affected.

Suggested reviewers: qiancai

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Title check ✅ Passed The title clearly identifies Japanese localization fixes for dropped particles and word-order issues in the best-practices documentation.
Description check ✅ Passed The description explains all changed files and required documentation corrections. It includes the affected version, AI involvement, reference-link section, and applicability checklist. The first-time…
✨ Finishing Touches 💡 1
🛠️ Fix failing CI checks 💡
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1


ℹ️ Review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Advanced

Run ID: 111483f5-f55d-4009-b744-d709161ed4e3

📥 Commits

Reviewing files that changed from the base of the PR and between a2da298 and a8066cf.

📒 Files selected for processing (3)
  • best-practices/grafana-monitor-best-practices.md
  • best-practices/multi-column-index-best-practices.md
  • best-practices/uuid.md

Included review availability: Your plan provides up to 4 included reviews per hour; 2 remain after this review.

Comment thread best-practices/uuid.md Outdated
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

missing-translation-status This PR does not have translation status info. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant