Skip to content

Add alya-small to the system tests - #931

Merged
MakisH merged 2 commits into
developfrom
alya-tests
Sep 22, 2026
Merged

MakisH merged 2 commits into
developfrom
alya-tests

Conversation

@MakisH

@MakisH MakisH commented Sep 21, 2026

Copy link
Copy Markdown
Member

Adds alya-small to the system tests, as an example of a restricted external code and case.

How the code and case are handled as sensitive:

  • Manually, the code is copied to the authorized runner
  • The case itself is extracted from the code, extended with a metadata.yaml
  • The Docker Compose file mounts the code directory as additional build context (only accessing the code it needs)
  • The case is served as an archive via a local file URL
  • The reference results are stored in a runner-specific directory. The generate-reference-results.yaml workflow will generate them but fail to upload to the tutorials repository (which is fine, as there is nothing to upload).
  • The GitHub Actions workflows:
    • In the beginning, make the files available by moving them to the tests/ directory
    • In the end, it excludes the respective directories from the uploaded build artifact. The preCICE log files are still uploaded, but for more details, one would need to connect to the runner.

Testing in https://github.com/precice/tutorials/actions/runs/35691184247

Note that the case is partitioned to use 4+3 MPI ranks, but the current runner can only offer 4 (I will try to get a bigger one). I am running the case with --oversubscribe, which makes everything significantly slower: the case needs ~30min for three coupling time windows.

We could also set up a dedicated runner for restricted cases, but that would raise the complexity a bit (we would need yet another GHA workflow that picks the specific runner).

Checklist

  • I added a summary of any user-facing changes (compared to the last release) in the changelog-entries/<PRnumber>.md.

@MakisH MakisH self-assigned this Sep 21, 2026
@MakisH
MakisH force-pushed the alya-tests branch 3 times, most recently from ac90895 to 43e5c44 Compare September 22, 2026 05:32
@MakisH
MakisH marked this pull request as ready for review September 22, 2026 06:54
@MakisH
MakisH requested a review from uekerman September 22, 2026 06:54

@uekerman uekerman left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. You now don't check against the provided iterations and convergence file, but these are generated by the system tests in a first run. Correct?

@MakisH

MakisH commented Sep 22, 2026

Copy link
Copy Markdown
Member Author

The iterations file is checked bitwise against the generated one for these three coupling time windows. The exported interface is also checked, with a tolerance.

@uekerman

Copy link
Copy Markdown
Member

👍 But not the convergence file? For three time windows, the iterations file might not tell the complete story, but maybe sth for a different PR.

@MakisH

MakisH commented Sep 22, 2026

Copy link
Copy Markdown
Member Author

Opened an issue: #933

@MakisH
MakisH merged commit 17015c1 into develop Sep 22, 2026
1 check passed
@MakisH
MakisH deleted the alya-tests branch September 22, 2026 15:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants