Add alya-small to the system tests - #931
Merged
Merged
Conversation
MakisH
force-pushed
the
alya-tests
branch
3 times, most recently
from
September 22, 2026 05:32
ac90895 to
43e5c44
Compare
uekerman
approved these changes
Sep 22, 2026
uekerman
left a comment
Member
There was a problem hiding this comment.
Looks good to me. You now don't check against the provided iterations and convergence file, but these are generated by the system tests in a first run. Correct?
Member
Author
|
The iterations file is checked bitwise against the generated one for these three coupling time windows. The exported interface is also checked, with a tolerance. |
Member
|
👍 But not the convergence file? For three time windows, the iterations file might not tell the complete story, but maybe sth for a different PR. |
Member
Author
|
Opened an issue: #933 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds alya-small to the system tests, as an example of a restricted external code and case.
How the code and case are handled as sensitive:
metadata.yamlgenerate-reference-results.yamlworkflow will generate them but fail to upload to the tutorials repository (which is fine, as there is nothing to upload).tests/directoryTesting in https://github.com/precice/tutorials/actions/runs/35691184247
Note that the case is partitioned to use 4+3 MPI ranks, but the current runner can only offer 4 (I will try to get a bigger one). I am running the case with
--oversubscribe, which makes everything significantly slower: the case needs ~30min for three coupling time windows.We could also set up a dedicated runner for restricted cases, but that would raise the complexity a bit (we would need yet another GHA workflow that picks the specific runner).
Checklist
changelog-entries/<PRnumber>.md.