Add warning in perpendicular-flap/solid-openfoam and remove decomposeParDict - #932
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The perpendicular-flap provides a
solid-openfoamcase, which was always meant for quick testing in OpenFOAM-only setups, and is known to give different results (discussed in #515).While this is documented in the list of solver options, it is a bit hidden, and it is reasonable to assume that if it runs, it should be correct. @fsimonis noticed that when running in parallel, the case seems to run but ends up in zero displacement.
This PR:
run.shoutput, with a delay of 5s for the user to notice it. The warning also points to solids4foam as a better OpenFOAM-based solid case.decomposeParDict, so that the case fails to run in parallel.Note that the
solid-solids4foamcase runs correctly in parallel.