Repository navigation
Handle multiple scripts when deciding whether to hydrate blocks - #59
Merged
Merged
Conversation
|
Note Currently processing new changes in this PR. This may take a few minutes, please wait... ⚙️ Run configuration
📒 Files selected for processing (3)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
An empty
<script module></script>before an interactive instance script madeprimo buildskip the client bundle, leaving controls inert. The hydration check now inspects every script and bundles the block when any script has content.Adds a regression fixture that verifies the counter bundle and hydration import. The startup test also selects an isolated port so an existing server on port 3000 cannot affect its result.
Validation: the full suite with companion PRs #57 and #58 passes on Node 22: 132 passed, two skipped. The same suite passes against the prepared primo-mcp 0.1.10 package. Completes the hydration correction for #58.
Summary by CodeRabbit