Repository navigation
Add explicit hosted publication and draft/public status - #60
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configuration
📒 Files selected for processing (14)
Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review. 📝 WalkthroughWalkthroughAdds hosted draft publication as a standalone command and as an option after successful pushes. The CLI reports push and publication outcomes separately, supports hosted publication status, and documents target selection, result states, and retry behavior. ChangesHosted Draft Publication
Priority: ➖ Normal Estimated code review effort: 4 (Complex) | ~45 minutes Change: Feature Sequence Diagram(s)sequenceDiagram
participant CLI as primo publish or primo push --publish
participant PublishCommand as publish_site
participant TargetResolver as hosted_targets
participant Workflow as publish_target
participant CMS as CMS publication API
CLI->>PublishCommand: pass hosted publication options
PublishCommand->>TargetResolver: resolve targets
TargetResolver-->>PublishCommand: return selected targets
PublishCommand->>Workflow: publish each target
Workflow->>CMS: check revision and start attempt
Workflow->>CMS: activate compiled attempt
CMS-->>Workflow: return publication receipt or status
Workflow-->>PublishCommand: return publication result
Merge Risk: ⚪ Minimal · up to This change keeps plain push draft-only and adds explicit publication and hosted status reporting. The review found no outstanding concrete defects, so it appears ready to merge after normal checks and a coordinated CMS upgrade. Pre-merge checks |
|
A successful
primo pushcurrently updates the hosted draft while the public site can remain stale. Keep plain push draft-only, addprimo publishandpush --publish, and report draft/publication status explicitly.Validation: TypeScript build; all 151 CLI tests pass, including real-CMS draft-only, successful publication, failed compilation preserving the previous public build, and publication-only recovery.
Requires the companion CMS publication endpoints and migration: primocms/primo#1300. Agent reference update: primocms/mcp#26. Upgrade the CMS and CLI together, then pull to refresh baselines because compilation artifacts are excluded from the content fingerprint.
Summary by CodeRabbit
primo publishto publish hosted drafts without uploading local files, with options to select targets and receive JSON results.primo pushcan now publish after successfully saving changes with--publish, or return machine-readable results with--json. Preview mode does not apply or publish changes.primo statuscan report hosted draft and publication status.