Repository navigation
Conversation
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: true
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CLI-built pages rendered all sections inside one SSR page root, then called
hydrateseparately for each section. Valid interactive blocks therefore replaced existing DOM and duplicated head tags. The build now renders the page head separately and gives each section its own server-rendered root, preserving the existing zone wrappers, field props, styles, and client bundles.Refs primocms/primo#1309. This is the CLI counterpart to primocms/primo#1325.
Validation: a new test invokes the actual built CLI to initialize a workspace and build a site, serves the resulting files, and checks them in Chromium. It verifies unchanged SSR body/head nodes, one copy of head tags, scoped CSS, each blocks, a head-only block, and a working counter. It fails on upstream and passes with the fix. CI installs Chromium before running the suite. Playwright is a development dependency only.
Exact-package follow-up: normal npm installs hoist Svelte beside primo-cli. Static build previously searched hardcoded paths, missed that location and failed with “Could not find svelte package.” Resolve svelte/package.json through createRequire(import.meta.url), matching the compiler import. Added an actual npm-pack/extract/hoisted-dependency regression: fails before the fix and passes after. The revised CLI candidate passes all 161 installed-package tests on Node 22.13 (zero skips), including static browser hydration and three disposable CMS contracts. Full handoff retains 5/5 SSR nodes and all content/IDs. Final Node 24 verification also passes all 161 installed-package tests with zero skips, plus the complete handoff and six compiler regressions. A first-run hosted-library mock assertion failure did not reproduce in isolated or full repeated runs; cause remains unproven and evidence is retained. No merge or publication.