Repository navigation
Conversation
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: true
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The CLI advertises Node 18, but Inquirer imports Node built-ins unavailable there, so even
primo --versionfails before an actionable message appears. Require Node 22.13+ within 22.x or Node 24+, document that range, and check it in a dependency-free package executable before importing the CLI. Tests follow the declared executable; CI covers the supported minimum, Node 24, and rejection on Node 20.Validation: the combined release candidate's full built-CLI suite on actual Node 22.13.0 has 158 passes, zero failures and three real-CMS skips; those three pass separately against the rebuilt CMS. Node 24.0.0 targeted checks have nine passes. Node 18.18.0 and 20.19.5 return the explicit upgrade message. The package inventory includes the executable bootstrap, and the full MCP/CLI/client handoff passes. Both Node matrix jobs pass in this PR's CI.
Discovered during founding-builder readiness QA. No package publication, deployment or merge.