Skip to content

Require supported Node versions and show an early upgrade message - #66

Draft
elemdos wants to merge 1 commit into
masterfrom
fix/supported-node-versions
Draft

elemdos wants to merge 1 commit into
masterfrom
fix/supported-node-versions

Conversation

@elemdos

@elemdos elemdos commented Oct 15, 2026 •

Copy link
Copy Markdown
Contributor

The CLI advertises Node 18, but Inquirer imports Node built-ins unavailable there, so even primo --version fails before an actionable message appears. Require Node 22.13+ within 22.x or Node 24+, document that range, and check it in a dependency-free package executable before importing the CLI. Tests follow the declared executable; CI covers the supported minimum, Node 24, and rejection on Node 20.

Validation: the combined release candidate's full built-CLI suite on actual Node 22.13.0 has 158 passes, zero failures and three real-CMS skips; those three pass separately against the rebuilt CMS. Node 24.0.0 targeted checks have nine passes. Node 18.18.0 and 20.19.5 return the explicit upgrade message. The package inventory includes the executable bootstrap, and the full MCP/CLI/client handoff passes. Both Node matrix jobs pass in this PR's CI.

Discovered during founding-builder readiness QA. No package publication, deployment or merge.

@coderabbitai

coderabbitai Bot commented Oct 15, 2026

Copy link
Copy Markdown

Important

Draft PR not reviewed

Draft PRs are not automatically reviewed by default.

  • Trigger a manual review

To automatically review draft PRs, update your CodeRabbit configuration:

reviews:
  auto_review:
    drafts: true
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant