Update deploy.yaml trigger to be upon release publishing - #4267
Open
clairep94 wants to merge 1 commit into
Open
Conversation
…f merges to the release branch
clairep94
changed the title
deploy.yaml trigger to be upon release publishing
clairep94
marked this pull request as ready for review
August 24, 2026 00:20
Collaborator
Author
|
Hold off on this one till #4281 is addressed |
There was a problem hiding this comment.
🟡 Changes recommended
Deploy safety/traceability regressions are introduced by removing the previous branch/test gating and by not tagging images with the release version.
Once you've addressed the issues Copilot identified, you can request another Copilot review.
Pull request overview
Updates the production deployment GitHub Actions workflow to run when a GitHub Release is published, aligning deployments with the release-publishing flow instead of merges to a specific branch.
Changes:
- Switched
deploy.ymltrigger fromworkflow_run(Test onreleasebranch) toreleaseevent (published). - Updated checkout to build from the published release tag (
github.event.release.tag_name).
File summaries
| File | Description |
|---|---|
| .github/workflows/deploy.yml | Changes the deployment trigger to release.published and checks out the published release tag for the production build/deploy. |
Review details
- Files reviewed: 1/1 changed files
- Comments generated: 2
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Comment on lines
2
to
+5
| on: | ||
| workflow_run: | ||
| workflows: ["Test"] | ||
| branches: | ||
| - release | ||
| release: | ||
| types: | ||
| - completed | ||
| - published |
Comment on lines
18
to
22
| - name: Check out the repo | ||
| uses: actions/checkout@v3 | ||
| with: | ||
| ref: release | ||
| ref: ${{ github.event.release.tag_name }} | ||
| - name: Set up Docker Buildx |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue:
Fixes #
Remake of #4252
deployworkflow trigger to be upon publishing a release on Github UI (instead of merges into thereleasebranch)Demo:
Changes:
I have verified that this pull request:
npm run lint)npm run test)npm run typecheck)developbranch.Fixes #123