Skip to content

affiliate: store a merchant with update-or-insert #255

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ralyodio merged 2 commits into from
Sep 13, 2026
Merged

affiliate: store a merchant with update-or-insert #255

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ac55015
affiliate: store a merchant with update-or-insert, since upsert canno…
ralyodio Sep 13, 2026
7230564
affiliate: the same update-or-insert for joins, whose index is also o…
ralyodio Sep 13, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
55 changes: 17 additions & 38 deletions lib/affiliate/directory.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -90,36 +90,17 @@ export async function addOrRefreshProgram(input: string, addedBy: string | null)
}
return { ok: false, error: found.error };
}
const { data, error } = await svc
.from("affiliate_programs")
.upsert(
{
origin: found.origin,
descriptor: found.raw,
verified: found.verified,
fetched_at: now,
error: null,
added_by: addedBy,
updated_at: now,
},
{ onConflict: "origin" },
)
.select("id, origin, descriptor, verified, fetched_at, error")
.single();
if (error || !data) {
// The unique index is on lower(origin), which upsert cannot target; fall back to update-or-insert.
const existing = await directoryRow(found.origin);
if (existing) {
await svc
.from("affiliate_programs")
.update({ descriptor: found.raw, verified: found.verified, fetched_at: now, error: null, updated_at: now })
.eq("id", existing.id);
const row = await directoryRow(found.origin);
return row ? { ok: true, row, warnings: found.warnings } : { ok: false, error: "Could not store the program." };
}
return { ok: false, error: error?.message ?? "Could not store the program." };
}
return { ok: true, row: toRow(data), warnings: found.warnings };
// The unique index is on lower(origin), which a PostgREST upsert cannot
// name, so: update the row that exists, else insert.
const existing = await directoryRow(found.origin);
const patch = { descriptor: found.raw, verified: found.verified, fetched_at: now, error: null, updated_at: now };
const { error } = existing
? await svc.from("affiliate_programs").update(patch).eq("id", existing.id)
: await svc.from("affiliate_programs").insert({ origin: found.origin, added_by: addedBy, ...patch });
if (error) return { ok: false, error: error.message };
const row = await directoryRow(found.origin);
if (!row) return { ok: false, error: "Could not store the program." };
return { ok: true, row, warnings: found.warnings };
}

/** Re-read every merchant not read in the last day (spec, "Directories" rule 1). */
Expand Down Expand Up @@ -233,14 +214,12 @@ export async function joinExternal(
const mine = await ensureMembershipForUser(user);
if (!mine) return { ok: false, error: "Could not create your CrawlProof affiliate profile." };

const { data: inserted, error: insErr } = await svc
.from("affiliate_joins")
.upsert(
{ owner_id: user.id, origin: row.origin, program_id: program.id, status: "pending", terms: program.pays, updated_at: new Date().toISOString() },
{ onConflict: "owner_id,origin,program_id", ignoreDuplicates: false },
)
.select(JOIN_COLUMNS)
.single();
// Same lower(origin) index as the directory: a refused or ended twin is
// reopened in place, otherwise a fresh row is inserted.
const fresh = { owner_id: user.id, origin: row.origin, program_id: program.id, status: "pending", terms: program.pays, error: null, updated_at: new Date().toISOString() };
const { data: inserted, error: insErr } = twin
? await svc.from("affiliate_joins").update(fresh).eq("id", twin.id).select(JOIN_COLUMNS).single()
: await svc.from("affiliate_joins").insert(fresh).select(JOIN_COLUMNS).single();
if (insErr || !inserted) return { ok: false, error: insErr?.message ?? "Could not start the join." };

const site = env.siteUrl.replace(/\/$/, "");
Expand Down
Loading