Fix new ads excluded by the 100-creative serving limit - #262
Merged
Merged
Conversation
ThreatCrush Security Scan48 finding(s) HIGH/CRITICAL: 2 | MEDIUM: 31 | LOW: 15
Snippets are redacted; ThreatCrush never prints matched credential material. |
ralyodio
marked this pull request as ready for review
September 16, 2026 03:38
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The ad selector queried only 100 ready creatives per format before running its auction. With 374 eligible campaigns in production, the newest campaigns were excluded from every format's candidate pool despite being active with ready creatives. Older campaigns continued recording impressions.
Load the complete eligible pool using ordered ID pagination, then run the existing auction. If an inventory page fails, log the failure and use the house ad instead of auctioning an incomplete pool. This requires no database migration.
Validation:
Not deployed. Loading full inventory increases the candidate payload; the current 374-row pool fits in a single 500-row page.