Fix HLS audio initialization and avoid reloading during player recovery - #213
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The production browser check exposed AAC headers missing from newly normalized fragmented MP4. Video frames decoded in FFmpeg, but remuxing that stream into HLS could produce invalid AAC packets and trigger repeated browser recovery. Delay the initial MP4 header until the AAC bitstream filter has produced its audio configuration.
Keep transient engine recovery separate from the room's terminal-error/rejoin handling, including MediaSource-aborted play requests. Also avoid retaining an extra fragment at the six-second buffer boundary due to timestamp rounding.
Validation: real course excerpts now play through HLS without decoding errors; a new automated browser test decodes red/blue/green video and audio across three files and mixed source codecs. AAC initialization headers and transient-versus-terminal player recovery have regression tests. Type checks and builds pass.