Re-render Series One and Two faces without the finish pass - #18
Merged
Merged
Conversation
Series One's shipped backs carried a smear of flat leather across the lower third, and its fronts a slab of brushed metal under the name: both were the image-to-image enhance pass filling regions the template left empty. Series Two shipped the same pass's invented quotes, stat panels and a misspelled name. Both templates now leave nothing to fill: the front portrait window grows to 72% as on Series Three onwards, the back's empty spacer becomes the set-emblem watermark, and the collector note is a labelled CURATOR'S NOTE rather than a quotation attributed to the subject. Series One stars now follow rarity. render-cards.mjs is rewritten around the committed approved portraits: it finds Chromium the way the later sets do, renders to dist/html and publishes the 500x745 web faces to public/cards in one run, with no API calls. All 47 Series One and 30 Series Two faces are regenerated from it. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Hy3fvgzA2YUtcsq2weByY4
ThreatCrush Security Scan7 finding(s) MEDIUM: 7
Snippets are redacted; ThreatCrush never prints matched credential material. |
ralyodio
marked this pull request as ready for review
September 13, 2026 00:00
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Series One's shipped card backs had a smear of flat leather across the lower third, and the fronts a slab of brushed metal under the name. Both were the image-to-image enhance pass filling regions the template left empty. Series Two shipped the same pass's invented quotes, invented stat panels and a misspelled name (#14).
This re-renders all 47 Series One and 30 Series Two faces as text-accurate HTML renders from the committed approved portraits, with no API calls, and fixes the templates so there is nothing left to fill:
scripts/render-cards.mjsrewritten: usesassets/portraits/legends/, finds Chromium the way the later sets do, and publishes the 500x745 web faces intopublic/cards/in one run.Trade-off
This drops the "premium finish" on Series One and Two. Those two sets now match the flat house style of Series Three to Six. Re-finishing is possible later, but only with a face-by-face check.
Verified
tsc --noEmitpasses. The only change tosrc/data/hacking.tsis the art path lines the publish step rewrites.🤖 Generated with Claude Code
https://claude.ai/code/session_01Hy3fvgzA2YUtcsq2weByY4