An audio option, for a station that is HLS but has no picture - #7
Merged
Merged
Conversation
The audio shape was inferred from the source alone, so an .mp3 got the compact bar and everything else got a 16:9 stage. A SiriusXM channel is a .m3u8 whose playlist carries nothing but AAC, and it was drawn as a black stage with a LIVE badge over a picture that never arrives. createPlayer now takes audio: true, and also reads it from an <audio> element handed in through media. 0.6.0. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Ac4GWmd6Nfd8JReX9u7kH1
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The audio shape was inferred from the source alone: an
.mp3got the compact bar, everything else a 16:9 stage. A SiriusXM channel is an.m3u8whose playlist carries nothing but AAC, and it was drawn as a black stage with a LIVE badge over a picture that never arrives.Now:
createPlayertakesaudio: true, and infers it when the element passed asmediais an<audio>. Nothing changes for a caller that passes neither. Two tests cover the option and the inference. Version bumped to 0.6.0 so tipoffwatch.com can pin it for its SiriusXM player.🤖 Generated with Claude Code
https://claude.ai/code/session_01Ac4GWmd6Nfd8JReX9u7kH1