[Fix] restores non-grouped log get functionality - #129
Conversation
A change in project-chip#94 had an unintended side-effect of breaking the command to download un-grouped logs for a test run execution. This change restores the functionality and adds unit tests that would have caught the error.
|
Navigate logical layers of code changes, visualize relationships, and explore their blast radius. No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Advanced Run ID: 📒 Files selected for processing (3)
Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review. 📝 WalkthroughWalkthrough
Priority: ⬇️ Low Merge Risk: ⚪ Minimal · up to The change restores plain-text log downloads and adds coverage for API responses, CLI output, and file writing. No material issue remains that should prevent merging after normal checks. 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
This pull request does not currently match the merge queue conditions, so it cannot be queued from here. The box comes back if it matches again. |
A change in #94 had an unintended side-effect of breaking the command to download un-grouped logs for a test run execution. This change restores the functionality and adds unit tests that would have caught the error.