Skip to content

[Fix] restores non-grouped log get functionality - #129

Merged
rquidute merged 1 commit into
project-chip:v2.16-cli-developfrom
greens:fix/log_get
Oct 2, 2026
Merged

rquidute merged 1 commit into
project-chip:v2.16-cli-developfrom
greens:fix/log_get

Conversation

@greens

@greens greens commented Oct 1, 2026

Copy link
Copy Markdown
Contributor

A change in #94 had an unintended side-effect of breaking the command to download un-grouped logs for a test run execution. This change restores the functionality and adds unit tests that would have caught the error.

A change in project-chip#94 had an unintended side-effect of breaking the command to download un-grouped logs for a test run execution. This change restores the functionality and adds unit tests that would have caught the error.
@coderabbitai

coderabbitai Bot commented Oct 1, 2026 •

Copy link
Copy Markdown

Review in Change Stack →

Navigate logical layers of code changes, visualize relationships, and explore their blast radius.

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Advanced

Run ID: 5dc390a3-606a-4860-8212-3ca66cd45321

📥 Commits

Reviewing files that changed from the base of the PR and between f2669d8 and b197b2f.

📒 Files selected for processing (3)
  • scripts/datamodel_generate_client.py
  • tests/test_api_client.py
  • th_cli/api_lib_autogen/api_client.py

Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review.


📝 Walkthrough

Walkthrough

ApiClient.send returns response text for successful responses when type_ is None. It returns None for HTTP 204 responses. Typed responses continue through the existing validation path. Tests cover API response handling, the generated log-download method, and test-run-execution log output and file writing.

Priority: ⬇️ Low

Merge Risk: ⚪ Minimal · up to b197b

The change restores plain-text log downloads and adds coverage for API responses, CLI output, and file writing. No material issue remains that should prevent merging after normal checks.

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 15.38% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 13 functions across 3 files. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly identifies the main change: restoring non-grouped log download functionality.
Description check ✅ Passed The description explains the broken log-download command, the cause, the fix, and the added unit tests. It directly matches the changeset.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
  • Fix all pre-merge checks with AI
  • Autopilot · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Autopilot is currently an internal CodeRabbit preview.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@mergify

mergify Bot commented Oct 1, 2026 •

Copy link
Copy Markdown

This pull request does not currently match the merge queue conditions, so it cannot be queued from here. The box comes back if it matches again.

@rquidute
rquidute merged commit b8c2d45 into project-chip:v2.16-cli-develop Oct 2, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants