Skip to content

[WALLET-425] Allow insecure result URI in x401 Result Artifact decoding - #32

Merged
frostevent merged 1 commit into
mainfrom
jeremie/wallet-425
Oct 9, 2026
Merged

frostevent merged 1 commit into
mainfrom
jeremie/wallet-425

Conversation

@frostevent

Copy link
Copy Markdown
Collaborator

Ticket: https://notarize.atlassian.net/browse/WALLET-425

What changed

  • verifier.decodeResultArtifact(header, options) and parseResultArtifact(value, options) accept { allowInsecureUri }. When it is set, an http credential_result_uri is accepted, so a verifier can use a http://localhost transport during local development. Without the option, the URI must still be https.
  • The https check is shared by return_uri and credential_result_uri, through isAllowedUri.
  • InsecureUriOptions is exported, and ReturnUriOptions is kept as an alias of it so existing callers keep compiling.

Testing

  • yarn check-all passes: format, lint, typecheck, 41/41 tests, publint.
  • New tests cover an http credential_result_uri accepted under allowInsecureUri, and a non-string URI still rejected.
  • Exercised locally in verifier-vcp-demo against a localhost notarize-api.

🤖 Generated with Claude Code

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@frostevent
frostevent merged commit 986219e into main Oct 9, 2026
8 checks passed
@frostevent
frostevent deleted the jeremie/wallet-425 branch October 9, 2026 08:44
@frostevent frostevent mentioned this pull request Oct 9, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant