Repository navigation
[WALLET-425] Allow insecure result URI in x401 Result Artifact decoding - #32
Merged
Merged
Conversation
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ticket: https://notarize.atlassian.net/browse/WALLET-425
What changed
verifier.decodeResultArtifact(header, options)andparseResultArtifact(value, options)accept{ allowInsecureUri }. When it is set, an httpcredential_result_uriis accepted, so a verifier can use ahttp://localhosttransport during local development. Without the option, the URI must still be https.return_uriandcredential_result_uri, throughisAllowedUri.InsecureUriOptionsis exported, andReturnUriOptionsis kept as an alias of it so existing callers keep compiling.Testing
yarn check-allpasses: format, lint, typecheck, 41/41 tests, publint.credential_result_uriaccepted underallowInsecureUri, and a non-string URI still rejected.🤖 Generated with Claude Code