Repository navigation
Unbiased ints (breaking, 3.0.0) - #2
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ints() used floor(min + float * max). When max doesn't divide 2^32, some results come up one draw more often than others. When max is above 2^32 it could only return multiples of 2^(bits over 32). This switches to Lemire's multiply-shift with rejection: it gives exactly the same value as the old mapping for every accepted u32 (0 differences in 5.2M sampled draws at max 1e6/1e9/3e9) and redraws the rest. It's breaking because a draw that hits a rejected value now returns a different number. That happens to (2^32 mod max)/2^32 of integers: ~1e-9 at max=6, 0.0225% at max=1e6, 6.9% at max=1e9, 30% at max=3e9. max > 2^32 now throws. floats, ByteGenerator, bytesToFloat and floatToInt are unchanged. Tests: 180 pass, including new rejection vectors. Release after merge: npm version major.