Repository navigation
test(key-recovery): deterministic non-OneHook QR case - #26
Merged
Merged
Conversation
Random bytes failed ~2.4% of runs: base45 includes a space and open() trims the scanned text, so a
random code with a leading/trailing space decoded misaligned ('corrupt'). Use fixed foreign bytes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the flaky test that failed the frontend pipeline run for 310f4a0. Random 120-byte input produced a base45 string starting/ending with a space ~2.4% of the time (119/5000, all with an edge space); open() trims, so it decoded as 'corrupt'. Test-only change.