Repository navigation
Remove redundant identity multiplications in SCCNN - #396
Merged
flovertiq merged 2 commits intoNov 7, 2026
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #396 +/- ##
==========================================
+ Coverage 96.36% 96.79% +0.42%
==========================================
Files 58 58
Lines 2092 2090 -2
==========================================
+ Hits 2016 2023 +7
+ Misses 76 67 -9 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
flovertiq
approved these changes
Nov 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change removes three dense identity matrices and seven identity multiplications from
SCCNNLayer.forward. Multiplying a signal by an identity matrix is unnecessary, and allocating these matrices adds memory and computation costs that grow with the number of cells in a batch.The implementation uses the signals directly while preserving the filter layout, learned parameters, and surrounding operations. It also removes the unused node, edge, and triangle counts.
A small regression test isolates the seven identity terms and checks outputs and input/parameter gradients for
sc_order=2andsc_order=3. This is made by ChatGPT (GPT-6 Astra).Validation:
pyg-libwas unavailable locally.This optimization comes from a joint INF319 project by Christina Holthe and Kathrine Nordnes Olsen (at University of Bergen)