turtledemo example viewer decodes scripts with the locale default encoding

[tonghuaroot]

Bug report

The turtledemo example viewer opens each demo script for display with
open(self.module.__file__, 'r') in DemoWindow.loadfile
(Lib/turtledemo/__main__.py). No encoding argument is passed, so the
source is decoded with the locale default encoding.

This emits an EncodingWarning under -X warn_default_encoding, and on a
non-UTF-8 locale (for example Windows cp1252) it can mis-decode a demo whose
source is UTF-8 or carries a PEP 263 coding cookie, showing mojibake in the
viewer.

It is the only unspecified-encoding open() in Lib/turtledemo.

Reproduction

Launching the viewer under -X warn_default_encoding and loading any example
reaches open(self.module.__file__, 'r') in DemoWindow.loadfile, which
raises under -W error::EncodingWarning:

EncodingWarning: 'encoding' argument not specified

On a non-UTF-8 locale the same call decodes the source with the wrong codec.

Fix

Read the source with tokenize.open(), which decodes using the encoding
detected from the file (its PEP 263 coding cookie, else UTF-8). That is the
correct encoding for reading Python source, and it matches how the module was
just imported one line above.

Linked PRs

• gh-153319: Read turtledemo scripts as UTF-8 #153321
• [3.15] gh-153319: Read turtledemo scripts with the source file's own encoding (GH-153321) #157872
• [3.14] gh-153319: Read turtledemo scripts as UTF-8 (GH-153321) #157873
• [3.13] gh-153319: Read turtledemo scripts as UTF-8 (GH-153321) #157874

[aisk]

Hi, thank you for your report. I noticed that most of the issues you opened do not have any labels. I guess you selected Blank issue when creating them.

If you are sure it is a bug, please use the "Bug report" template. It has a better format and adds the type-bug label automatically. This helps us triage the issue. Document issue and other have their own template which you can choose from.

[1137MOM]

[p ]()