Conversation
Replace soft deprecated PyBytes_FromStringAndSize() with PyBytesWriter. Use PyBytesWriter_Create() for the float code path, or PyMem_Malloc() for the int code path.
vstinner
commented
Aug 13, 2026
| } | ||
| else { | ||
| writer = NULL; | ||
| buf = PyMem_Malloc(n + 1); |
Member
Author
There was a problem hiding this comment.
PyLong_FromString() doesn't need a bytes object, just a C string (char*). But maybe the PyLong code path should also use PyBytesWriter to simplify the code.
Member
Author
|
The alternative to creating a temporary bytes object is... to not create a Python object at all :-) I wrote PR gh-156897 for that. |
Member
Author
|
I close this PR since PR #156897 seems to be a better approach. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace soft deprecated PyBytes_FromStringAndSize() with PyBytesWriter.
Use PyBytesWriter_Create() for the float code path, or PyMem_Malloc() for the int code path.