gh-157695: Rename HAVE_FLOAT16 macro to _Py_HAVE_FLOAT16

[vstinner]

• Issue: The Python C API should only define macros with a name starting wit Py #157695

[vstinner]

The macro was added by commit e7ef46a (PR gh-154796).

cc @skirpichev

[skirpichev]

Looks good for me, assuming case for _Py_FFI_SUPPORT_C_COMPLEX.

Though, I don't see much difference wrt this define and HAVE_* defines, coming from the configure script.

[vstinner]

Merged. Thanks for your review.

[bedevere-bot]

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

Hi! The buildbot AMD64 CentOS9 LTO 3.x (tier-1) has failed when building commit 1d0f1ad.

What do you need to do:

1. Don't panic.
2. Check the buildbot page in the devguide if you don't know what the buildbots are or how they work.
3. Go to the page of the buildbot that failed (https://buildbot.python.org/#/builders/831/builds/9417) and take a look at the build logs.
4. Check if the failure is related to this commit (1d0f1ad) or if it is a false positive.
5. If the failure is related to this commit, please, reflect that on the issue and make a new Pull Request with a fix.

You can take a look at the buildbot page here:

https://buildbot.python.org/#/builders/831/builds/9417

Summary of the results of the build (if available):

==

Click to see traceback logs

Note: switching to '1d0f1ad0aa7a933e8d03f855d9b5eed7e00e775d'.

You are in 'detached HEAD' state. You can look around, make experimental
changes and commit them, and you can discard any commits you make in this
state without impacting any branches by switching back to a branch.

If you want to create a new branch to retain commits you create, you may
do so (now or later) by using -c with the switch command. Example:

  git switch -c <new-branch-name>

Or undo this operation with:

  git switch -

Turn off this advice by setting config variable advice.detachedHead to false

HEAD is now at 1d0f1ad0aa7 gh-157695: Rename HAVE_FLOAT16 macro to _Py_HAVE_FLOAT16 (#157752)
Switched to and reset branch 'main'

Parser/lexer/string.c: In function ‘finish_ftstring_expr’:
Parser/lexer/string.c:81:20: warning: variable ‘previous_end’ set but not used [-Wunused-but-set-variable]
   81 |         _PyTok_Off previous_end = state->expr_span.start;
      |                    ^~~~~~~~~~~~
In function ‘bytearray_resize_storage’,
    inlined from ‘bytearray_resize_lock_held’ at Objects/bytearrayobject.c:334:9,
    inlined from ‘bytearray_append_impl’ at Objects/bytearrayobject.c:2195:9,
    inlined from ‘bytearray_append’ at Objects/clinic/bytearrayobject.c.h:1248:20:
Objects/bytearrayobject.c:254:13: warning: ‘memmove’ specified bound 18446744073709551615 exceeds maximum object size 9223372036854775807 [-Wstringop-overflow=]
  254 |             memmove(self->ob_bytes + moved, old_start + moved, remaining);
      |             ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
Python/ceval.c: In function ‘_Py_BuildMap_StackRefSteal’:
Python/ceval.c:945:11: warning: ‘args_o_temp’ may be used uninitialized [-Wmaybe-uninitialized]
  945 |     res = _PyDict_FromItems(
      |           ^~~~~~~~~~~~~~~~~~
  946 |         args_o, 2,
      |         ~~~~~~~~~~
  947 |         args_o+1, 2,
      |         ~~~~~~~~~~~~
  948 |         half_args
      |         ~~~~~~~~~
  949 |     );
      |     ~      
In file included from Python/ceval.h:11,
                 from Python/ceval.c:3:
./Include/internal/pycore_dict.h:333:23: note: by argument 3 of type ‘struct PyObject * const *’ to ‘_PyDict_FromItems’ declared here
  333 | PyAPI_FUNC(PyObject *)_PyDict_FromItems(
      |                       ^~~~~~~~~~~~~~~~~
In file included from Python/ceval.c:704:
Python/ceval.c:940:52: note: ‘args_o_temp’ declared here
  940 |     STACKREFS_TO_PYOBJECTS(arguments, half_args*2, args_o);
      |                                                    ^~~~~~
lto-wrapper: warning: using serial compilation of 2 LTRANS jobs
lto-wrapper: warning: using serial compilation of 2 LTRANS jobs
lto-wrapper: warning: using serial compilation of 3 LTRANS jobs
lto-wrapper: warning: using serial compilation of 2 LTRANS jobs
lto-wrapper: warning: using serial compilation of 2 LTRANS jobs
lto-wrapper: warning: using serial compilation of 2 LTRANS jobs
lto-wrapper: warning: using serial compilation of 4 LTRANS jobs
lto-wrapper: warning: using serial compilation of 3 LTRANS jobs
lto-wrapper: warning: using serial compilation of 2 LTRANS jobs
lto-wrapper: warning: using serial compilation of 2 LTRANS jobs
lto-wrapper: warning: using serial compilation of 3 LTRANS jobs
lto-wrapper: warning: using serial compilation of 3 LTRANS jobs
lto-wrapper: warning: using serial compilation of 2 LTRANS jobs
lto-wrapper: warning: using serial compilation of 4 LTRANS jobs
lto-wrapper: warning: using serial compilation of 84 LTRANS jobs
lto-wrapper: warning: using serial compilation of 91 LTRANS jobs
lto-wrapper: warning: using serial compilation of 91 LTRANS jobs

make: *** [Makefile:2488: buildbottest] Error 3

Expanding reachable commits in commit graph: 88674
Expanding reachable commits in commit graph: 171223, done.