Conversation
miyanyan
requested review from
AA-Turner,
corona10,
emmatyping,
erlend-aasland,
gpshead,
itamaro and
picnixz
as code owners
September 18, 2026 14:04
|
All commit authors signed the Contributor License Agreement. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #157755.
The OpenSSL API checks put
LIBSbeforeOPENSSL_LIBSandLIBCRYPTO_LIBS. With static OpenSSL, this can place its dependencies before the libraries that reference them and incorrectly mark_ssland_hashlibas missing.Place the OpenSSL libraries before
LIBS, matching the existingAX_CHECK_OPENSSLcheck. Regenerateconfigurewith Autoconf 2.72 and add a NEWS entry.For example, with zlib-enabled static OpenSSL and
libz.asupplied throughLIBS, the initial OpenSSL link check succeeds but both API checks fail with unresolved zlib symbols. Both checks pass after this change with identical configure arguments. Reproduction details are in the linked issue.