Skip to content

Fix missing get_rl_tempfile in __all__ export - #16311

Draft
mxr wants to merge 1 commit into
python:mainfrom
mxr:patch-1
Draft

Fix missing get_rl_tempfile in __all__ export#16311
mxr wants to merge 1 commit into
python:mainfrom
mxr:patch-1

Conversation

@mxr

@mxr mxr commented Aug 28, 2026

Copy link
Copy Markdown
Contributor

I think this was a copy paste error but let me know


2026-08-29 (@srittau): Deferred until fixed by upstream.

I think this was a copy paste error but let me know
@github-actions

Copy link
Copy Markdown
Contributor

According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉

@AlexWaygood

Copy link
Copy Markdown
Member

this is causing CI to fail -- does it actually exist in __all__ in the runtime package?

@donbarbos

Copy link
Copy Markdown
Contributor

This is indeed a problem, but it is present in the library itself, both in 4.3.1 version (the last version supported by typeshed) and in the source code of the latest version. As I understand it, in situations like this, the usual approach is to follow the actual runtime behavior and keep the stubs consistent with it.

I suggest reporting the issue to the reportlab development team:

Please do not use this for issue reporting etc; use the mail list at
https://pairlist2.pair.net/mailman/listinfo/reportlab-users

But this address didn't open for me, so I found this mirror on Google Groups: https://groups.google.com/g/reportlab-users

@mxr

mxr commented Aug 28, 2026

Copy link
Copy Markdown
Contributor Author

Nice find. Reported in the mailing list.

@AlexWaygood AlexWaygood added the status: deferred Issue or PR deferred until some precondition is fixed label Aug 28, 2026
@srittau
srittau marked this pull request as draft August 29, 2026 12:47
@mxr

mxr commented Sep 1, 2026

Copy link
Copy Markdown
Contributor Author

Robin from reportlab emailed back and said "[...] thanks for the contribution. It will be in next release"

@AlexWaygood

Copy link
Copy Markdown
Member

We'll have to wait until that release is out before merging this, unfortunately — the CI here will continue to fail in the meantime

@mxr

mxr commented Sep 1, 2026

Copy link
Copy Markdown
Contributor Author

Makes sense

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

status: deferred Issue or PR deferred until some precondition is fixed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants