Move the Samsung jobs from pull to trunk - #22611
Draft
huydhn wants to merge 1 commit into
Draft
Conversation
Both blocks move verbatim. They landed in pull.yml with the Exynos bring-up (#13677) as ordinary per-pull-request smoke tests, alongside the other backends', with no credentials and a 90 minute timeout. #15731 then gave them secrets: inherit, SAMSUNG_AI_LITECORE_KEY for the SDK download, timeouts of 180 and 360 minutes, and a skip for forks, since secrets are not available there. That combination belongs in trunk: a six hour credentialed job on the pull-request path costs every pull request and silently does nothing for external contributors. In trunk they run on main, on ciflow/trunk, and on pull requests touching .ci/scripts/**, which still covers setup-samsung-linux-deps.sh. The fork skip stays for that last case. Draft: this changes when the Exynos backend gets signal, so it wants an owner's agreement rather than mine. Authored with Claude Code.
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/22611
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit 5b9f1df with merge base 7dc8641 ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
meta-cla
Bot
added
the
CLA Signed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Draft — needs an Exynos owner's agreement, since it changes when they get signal.
Both blocks move verbatim. They landed in
pull.ymlwith the Exynos bring-up (#13677) as ordinary per-PR smoke tests next to the other backends', with no credentials and a 90 minute timeout. #15731 then addedsecrets: inherit,SAMSUNG_AI_LITECORE_KEYfor the SDK download, timeouts of 180 and 360 minutes, and a fork skip because secrets aren't available there. That combination belongs in trunk: a six hour credentialed job on the pull request path costs every PR and silently does nothing for external contributors.In
trunk.ymlthey run on main, onciflow/trunk, and on pull requests touching.ci/scripts/**— which still coverssetup-samsung-linux-deps.sh. The fork skip stays for that last case.Related: #22609 removes the
ciflow/trunk/*trigger frompull.yml, which was these jobs' only route to run against a fork PR's code. Landing this makes that a non-issue, since the label-triggered run becomes intentional rather than a side effect.cc @Jiseong-oh