Repository navigation
fix(form): a field skeleton always says what it waits for — 0.10.61 - #139
Merged
Merged
Conversation
FormFieldsSkeleton rendered `data-wait` only when its caller named a reason, and the two nested waits named none: AutoField resolving a named arg_schema, and the hash field loading its sub-schema. `data-wait` is also how a page asks whether a form has finished loading, so those placeholders were ones nothing could wait for; qorus-ide's Qlip build 279 captured the AI Guardrail creator's Rules row on one. `reason` now defaults to `loading`, so the skeleton is always marked, and both callers name `arg-schema`. 0.10.61. Closes #138
|
📦 Prerelease published for this PR: Install it in a consumer (updates yarn add @qoretechnologies/reqraft@0.10.61-pr.139.gddd4ce2Published under the |
qlip visual regression✅ No visual changes. |
davidnich
added a commit
that referenced
this pull request
Oct 8, 2026
#137's one patch bump moves to 0.10.62.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
FormFieldsSkeletonrendereddata-waitonly when its caller passedreason. The two nested waits passed none, so their placeholder carried no marker:AutoFieldwhile it resolves a namedarg_schema:<FormFieldsSkeleton rows={1} />(src/components/form/fields/auto/AutoFormField.tsx)<FormFieldsSkeleton rows={2} />(src/components/form/fields/Field.tsx)data-waitis also how a page asks whether a form has finished loading. qorus-ide's stories wait on[data-wait]before Qlip takes its picture, and Qlip build 279 captured Interfaces/AI Guardrail · Existing with the Rules row still on this skeleton: drake sendsruleswitharg_schema: "ai-guardrail-rules", and the story's loading wait could not see the placeholder.Fix
reasondefaults toloading, so aFormFieldsSkeletonis always marked, whoever renders it.AutoFieldand the hash field name their wait:arg-schema.Tests
__tests__/formFieldsSkeletonNamesItsWait.test.tsx(3 tests): the skeleton carries the reason it is given, is still marked with none, and anAutoFieldwaiting on a namedarg_schemashowsdata-wait="arg-schema". The last two fail without the fix.Run locally:
yarn precheck(lint, the full unit suite of 175 files / 1857 tests,build:test:prod). In qorus-ide, with this build linked in, the AI Guardrail stories pass 5/5 and Existing captures the settled Rules row.Closes #138