Fix compatibility with rubyntlm 0.6.8 - #305
Merged
Merged
Conversation
Initialize server target info with nil and ignore empty client target-info buffers while preserving validation of malformed nonempty data. Update session specs to use real credentials instead of mocking `is_anonymous?`, and add regression coverage for SMB1, SMB2, and DCE/RPC.
jheysel-r7
approved these changes
Sep 28, 2026
jheysel-r7
left a comment
jheysel-r7
left a comment
Contributor
There was a problem hiding this comment.
Thank you @cdelafuente-r7, looks great!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes compatibility with
rubyntlm0.6.8, whose target-info parser rejects empty strings. Server challenges now initialize target info withnil, and clients ignore absent or empty target-info buffers while continuing to reject malformed nonempty data.The session specs now use actual credentials and validate authentication results, avoiding mocks of
is_anonymous?that no longer intercept the gem’s internal calls. Regression coverage includes SMB1, SMB2, DCE/RPC, and serialized server target info.