Repository navigation
RDoc-4138 Search results link to random language, RDoc-4148 Sync Algolia config automatically & place it inside git - #2710
Open
poissoncorp wants to merge 2 commits into
Conversation
poissoncorp
force-pushed
the
RDoc-4138-search-results-language
branch
2 times, most recently
from
October 23, 2026 00:02
f3c87ed to
9aa02c6
Compare
poissoncorp
force-pushed
the
RDoc-4138-search-results-language
branch
from
October 23, 2026 01:13
9aa02c6 to
ccb9bf2
Compare
Lwiel
reviewed
Oct 23, 2026
Comment on lines
+280
to
+287
| # After the invalidation, so a recrawl reads this release's HTML; errors are held like the CloudFront sync. | ||
| Write-Host 'Syncing Algolia configuration' -ForegroundColor Cyan | ||
| try { | ||
| & $SyncAlgoliaPath | ||
| } catch { | ||
| if (-not $configError) { $configError = $_ } | ||
| Write-Host " Algolia config sync failed: $_" -ForegroundColor Red | ||
| } |
Contributor
There was a problem hiding this comment.
We don't wait for the invalidation to complete before executing this
Contributor
There was a problem hiding this comment.
We should also check $LASTEXITCODE here
| . (Join-Path $PSScriptRoot 'lib/cloudfront-common.ps1') | ||
|
|
||
| # node prints non-ASCII (the breadcrumb separator). | ||
| [Console]::OutputEncoding = [Text.UTF8Encoding]::new() |
Contributor
There was a problem hiding this comment.
Should we restore the default encoding at the end?
|
|
||
| const indexSettings = require("./algolia-index-settings.json"); | ||
|
|
||
| const INDEX_NAME = "ProductionDocsCrawler"; |
Contributor
There was a problem hiding this comment.
We already have it in docusaurus.config.ts, I'd rather keep this in some common place
| }; | ||
|
|
||
| const CRAWLER_CONFIG = { | ||
| appId: "GYTCYX561T", |
Contributor
There was a problem hiding this comment.
We already have it in docusaurus.config.ts, I'd rather keep this in some common place
| ], | ||
| safetyChecks: { | ||
| beforeIndexPublishing: { | ||
| maxLostRecordsPercentage: 50, |
Contributor
There was a problem hiding this comment.
I think we should increase this value for a single run, we'll drop a lot of index entries with this PR
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue link
RDoc-4138 Search results link to random language
RDoc-4148 Sync Algolia config automatically & place it inside git
Additional description
The crawler indexed each page's C# HTML under a random
?lang=URL, so search results opened a random language and saved it as the reader's preference.scripts/lib/algolia-*, as live, plus Quill results grouped under "Quill" with its landing page excluded, andinitialIndexSettingsfixed (was keyedProductioDocsCrawler)ignoreQueryParams: ["lang"], so each page is indexed under its plain URLscripts/sync-algolia.ps1pushes them on a diff and recrawls after a crawler change;deploy.ps1runs it after the CloudFront invalidation, skipped withoutALGOLIA_*credentialsVerified:
-DryRunagainst the live crawler and index shows only the intended diff. The write path first runs on deploy.Type of change
/templatesor readme)Changes in docs URLs
/scripts/redirects.jsonfile, setDocuments MovedPR label)Changes in UX/UI