Skip to content

RDBC-1161 RavenDB-27289 Require a value for every declared agent parameter - #320

Merged
poissoncorp merged 2 commits into
ravendb:v7.2from
poissoncorp:sdk-sync/RDBC-1161
Oct 22, 2026
Merged

poissoncorp merged 2 commits into
ravendb:v7.2from
poissoncorp:sdk-sync/RDBC-1161

Conversation

@poissoncorp

Copy link
Copy Markdown
Contributor

Agent parameter refusals from the server now reach Python callers as UnsupportedAiQueryParameterException and AiAgentParameterCollisionException, instead of a generic RavenException.

  • Changed: both exceptions added to raven_exceptions.py as AiException subclasses, mapped in the exception dispatcher and exported from ravendb. The server raises the first when a query binds a parameter whose value is not a scalar, the second when a name is both an agent parameter and a tool argument.
  • Not ported: the query comparison added to GenAiConfiguration.Compare, which is internal and has no Python counterpart.
  • Tests: 3 tests of RavenDB_27289 ported to ai_agent_tests/test_ravenDB_27289.py, gated on RAVENDB_LICENSE like the other agent tests. The other 10, and the GenAI tests in RavenDB_26767, drive server handlers with a mock LLM. Unit tests for the dispatcher mapping added to test_ai_agent_configuration.py.
  • Checks: black --check and test_ai_agent_configuration pass. The server tests and test_imports were not run locally because no test server was configured; the new exports import.

Ticket: RDBC-1161
C# change: ravendb/ravendb#23782

SDK Sync Agent

@poissoncorp

Copy link
Copy Markdown
Contributor Author

The failing check is not caused by this PR. No code change.

SDK Sync Agent

@poissoncorp

Copy link
Copy Markdown
Contributor Author

Merged v7.2 into this branch (e263426) to pick up the test fix from #318. No change to the code of this PR.

  • test_more_like_this: the test now accepts either order for the two posts that are equally similar to the first one.
  • black --check passes locally. The tests need a server and run only in CI.

SDK Sync Agent

@poissoncorp
poissoncorp merged commit efef431 into ravendb:v7.2 Oct 22, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

sdk-sync Port of C# client changes from an SDK sync task

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant