Repository navigation
RDBC-1161 RavenDB-27289 Require a value for every declared agent parameter - #320
Merged
Merged
Conversation
Contributor
Author
|
The failing check is not caused by this PR. No code change.
SDK Sync Agent |
Contributor
Author
|
Merged
SDK Sync Agent |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Agent parameter refusals from the server now reach Python callers as
UnsupportedAiQueryParameterExceptionandAiAgentParameterCollisionException, instead of a genericRavenException.raven_exceptions.pyasAiExceptionsubclasses, mapped in the exception dispatcher and exported fromravendb. The server raises the first when a query binds a parameter whose value is not a scalar, the second when a name is both an agent parameter and a tool argument.GenAiConfiguration.Compare, which is internal and has no Python counterpart.RavenDB_27289ported toai_agent_tests/test_ravenDB_27289.py, gated onRAVENDB_LICENSElike the other agent tests. The other 10, and the GenAI tests inRavenDB_26767, drive server handlers with a mock LLM. Unit tests for the dispatcher mapping added totest_ai_agent_configuration.py.black --checkandtest_ai_agent_configurationpass. The server tests andtest_importswere not run locally because no test server was configured; the new exports import.Ticket: RDBC-1161
C# change: ravendb/ravendb#23782
SDK Sync Agent