Repository navigation
The fork's Google Drive migration is idempotent, so a fresh database that also gets upstream's copy still migrates - #30
Merged
Conversation
…that also gets upstream's copy still migrates Signed-off-by: Bogdan Szabo <bogdan@re-cinq.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#29 renamed the migration to 9006 but committed the old content: plain
CREATE TABLE, no fork header. That runs fine today, but once the upstream sync brings deeplethe#1386's 0120 copy, a fresh database runs 0120 first and then fails on 9006. This commits theIF NOT EXISTSversion with the header.It must merge before any release is deployed: once 9006 has run in production its checksum is fixed and the file can't change. v0.1.0-re.18 carries the old file, so it should not be deployed.
Checked on fresh databases, rebuilding each time (
sqlx::migrate!embeds the files at compile time): 9006 alone, an existing database that later gets 0120, and a fresh one with both all migrate cleanly.