Classify react/nativemodule/defaults as for-frameworks - #58423
Open
coado wants to merge 1 commit into
Open
Conversation
Summary: Reclassify `DefaultTurboModules.h` from the private C++ Stable API tier to the "for frameworks" tier, and add the `#pragma once` the header was missing. `DefaultTurboModules::getTurboModule` is the entry point out-of-tree platforms and custom C++ hosts use to obtain React Native's core turbo modules. Its exported surface is a single static function over `std::string`, `CallInvoker` and the `TurboModule` base class, so it exposes no private type. The concrete `react/nativemodule/*` implementations it delegates to all remain private. Changelog: [Internal] Differential Revision: D119326878
meta-cla
Bot
added
the
CLA Signed
facebook-github-tools
Bot
added
p: Software Mansion
|
@coado has exported this pull request. If you are a Meta employee, you can view the originating Diff in D119326878. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Reclassify
DefaultTurboModules.hfrom the private C++ Stable API tier to the"for frameworks" tier, and add the
#pragma oncethe header was missing.DefaultTurboModules::getTurboModuleis the entry point out-of-tree platforms andcustom C++ hosts use to obtain React Native's core turbo modules. Its exported surface
is a single static function over
std::string,CallInvokerand theTurboModulebaseclass, so it exposes no private type. The concrete
react/nativemodule/*implementations it delegates to all remain private.
Changelog: [Internal]
Differential Revision: D119326878